Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Follow up to #20998 - Replace "Wallet" text in Rewards contexts to say "Brave Rewards" #24001

Closed
2 tasks
Uni-verse opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#14396
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 12, 2022

Description

Replace "Wallet" text in Rewards contexts to say "Brave Rewards." The following pages/modals still contain some wallet strings that may need to be replaced with Brave Rewards. Follow up to #20998, see for details.

  • Brave rewards wallet dropdown contains Wallet Verified/Verifed - There is copy mismatch when viewing on panel/rewards.
  • Brave Reset Rewards modal/prompt string - This will delete your brave wallet may need to reviewed by product.
brave://rewards/Panel Reset Rewards rewards-internals
screenshot-1657596141793 screenshot-1657595670808 screenshot-1657596291709

Steps to reproduce

  1. Clean install
  2. Enable Staging Rewards/Prod Rewards
  3. Log in to Custodial accounts, Uphold/Gemini
  4. Check mentioned pages/modals in description

Actual result

See description

Expected result

Strings containing Wallet need to be replaced with Brave Rewards in context of rewards

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet, Mobile - Galaxy Devices
  • Android version: 12

Brave version

1.41.95

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality labels Jul 12, 2022
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jul 12, 2022

@timchilds Product to investigate whether we should update the sections mentioned.

@Miyayes Miyayes changed the title Follow up to #20998 - Replace "Wallet" text in Rewards contexts to say "Brave Rewards" [Android] [Android] Follow up to #20998 - Replace "Wallet" text in Rewards contexts to say "Brave Rewards" Jul 19, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jul 19, 2022

Brave://rewards-internals - Section with heading Wallet info possibly will need to be reviewed so its not confused with anything brave wallet related.

I broke this out into a separate issue, since it's shared between desktop and Android: #24135.

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 21, 2022
@deeppandya deeppandya assigned deeppandya and unassigned vinodghai Jul 29, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 29, 2022
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Sep 21, 2022

Verified on Samsung Galaxy S21 & Galaxy Tab S7 using

Brave	1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit) 
Revision	872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS	Android 12; Build/SP1A.210812.016

Spot checked the areas in #24001 (comment) to copies are upgrade.

  • Verified "wallet" is removed from brave://rewards & rewards panel custodial login dropdown
  • Verified copy in the reset rewards prompt to show rewards instead of wallet
  • Verified Brave://rewards-internal general doesn't show wallet text for rewards
Reset Rewards BR Panel (logged in) brave://rewards page (logged in) rewards-internals
screenshot-1663771945246 screenshot-1663772113309 screenshot-1663772119387 screenshot-1663771926030
screenshot-1663776462050 screenshot-1663776437343 screenshot-1663776421739 screenshot-1663776304681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants