Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync device name should have restricted length #2131

Closed
GeetaSarvadnya opened this issue Nov 14, 2018 · 2 comments · Fixed by brave/brave-core#1019
Closed

Sync device name should have restricted length #2131

GeetaSarvadnya opened this issue Nov 14, 2018 · 2 comments · Fixed by brave/brave-core#1019

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2018

Description

Sync device name should have restricted length

Steps to Reproduce

  1. Launch brave beta with --enable-brave-sync flag
  2. Give sync name which has too many chars along with special chars and numbers

Actual result:

Sync Device name is accepting too many chars
image

Expected result:

There should be restriction for sync name length

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes on beta build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@kjozwiak @LaurenWags @srirambv @btlechowski

@GeetaSarvadnya GeetaSarvadnya added this to the 0.57.x - Beta milestone Nov 14, 2018
@GeetaSarvadnya GeetaSarvadnya added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 14, 2018
@cezaraugusto
Copy link
Contributor

😱

@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2018

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified laptops no longer have the option of having a user entered name

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7
  • Verified laptops no longer have the option of having a user entered name

Verification PASSED on Ubuntu 18.04.1 x64 VM using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux
  • Verified laptops no longer have the option of having a user entered name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment