Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint warnings in signing_helper.py #21376

Closed
bsclifton opened this issue Mar 1, 2022 · 1 comment · Fixed by brave/brave-core#12443
Closed

pylint warnings in signing_helper.py #21376

bsclifton opened this issue Mar 1, 2022 · 1 comment · Fixed by brave/brave-core#12443
Assignees
@bsclifton
Labels
ci-concern dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.36.x - Release

Comments

@bsclifton
Copy link
Member

Description

Changes to signing_helper.py in brave/brave-core#12418 caused pylint to run for the entire file. There are some warnings (all low severity except one normal)

signing_helper.py:17 Warning reimported Normal 1
signing_helper.py:46 Convention bad-continuation Low 1
signing_helper.py:52 Convention line-too-long Low 1
signing_helper.py:65 Convention line-too-long Low 1
signing_helper.py:70 Convention line-too-long Low 1
signing_helper.py:85 Convention line-too-long Low 1
signing_helper.py:99 Convention line-too-long Low 1
signing_helper.py:106 Convention line-too-long Low 1
signing_helper.py:144 Convention trailing-whitespace Low 1
signing_helper.py:144 Convention line-too-long Low 1
@bsclifton bsclifton self-assigned this Mar 1, 2022
@bsclifton bsclifton changed the title pylint warnings in signing_helper.py pylint warnings in signing_helper.py Mar 1, 2022
bsclifton added a commit to brave/brave-core that referenced this issue Mar 1, 2022
@bsclifton
Fix pylint warnings in signing_helper.py
250bbc3 
Fixes brave/brave-browser#21376
@bsclifton bsclifton mentioned this issue Mar 1, 2022
Merged
25 tasks
@bsclifton bsclifton added this to the 1.38.x - Nightly milestone Mar 1, 2022
This was referenced Mar 1, 2022
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2022

Thanks for getting this fixed @bsclifton 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
ci-concern dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Fix pylint warnings in signing_helper.py brave/brave-core
2 participants
@kjozwiak @bsclifton