Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PushClientChannel::UpdateCredentials #2141

Closed
pilgrim-brave opened this issue Nov 14, 2018 · 0 comments · Fixed by brave/brave-core#912
Closed

Disable PushClientChannel::UpdateCredentials #2141

pilgrim-brave opened this issue Nov 14, 2018 · 0 comments · Fixed by brave/brave-core#912
Assignees
@pilgrim-brave
Labels
audit-non-blocking privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@pilgrim-brave
Copy link

PushClientChannel is part of the invalidation subsystem. It's not clear when it even gets called (non-binding text documentation says it is "disabled by default" but "controlled by sync server experiments" -- which means it's controlled by Google. It is hooked up as an invalidation listener and the UpdateCredentials method can be triggered at any time and connects to a Google server.

We should at a minimum disable the PushClientChannel::UpdateCredentials method.
@pilgrim-brave pilgrim-brave self-assigned this Nov 14, 2018
@pilgrim-brave pilgrim-brave added audit-non-blocking privacy/connect This requires making a network connection to a third-party service. labels Nov 14, 2018
@pilgrim-brave pilgrim-brave added this to the 1.x Backlog milestone Nov 14, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Nov 15, 2018
@pilgrim-brave
Disable PushClientChannel
809905f 
Fixes brave/brave-browser#2141
@pilgrim-brave pilgrim-brave mentioned this issue Nov 15, 2018
Merged
18 tasks
@pilgrim-brave pilgrim-brave modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
audit-non-blocking privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Disable PushClientChannel brave/brave-core
2 participants
@bbondy @pilgrim-brave