Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update design for https warning interstitial #21669

Open
rebron opened this issue Mar 15, 2022 · 2 comments
Open

update design for https warning interstitial #21669

rebron opened this issue Mar 15, 2022 · 2 comments
Assignees
Labels
feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 15, 2022

Description

Current https only warning interstitial uses chromium look and feel and is not user friendly. Update design to assist users navigate through this warning.

Steps to Reproduce

  1. Turn on brave://settings/security Always use secure connections (https-only)
  2. Visit a site that's http only e.g. http://ejfry.com or http://howbigismybrowser.com or your choice
  3. Notice interstitial screen attached in actual result. Clicking through should take you to http site.

Actual result:

Screen Shot 2022-03-15 at 8 12 11 AM

Expected result:

[design placeholder]

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Required change before turning https-only on by default.
cc: @diracdeltas @fmarier @iefremov @Brave-Matt

@rebron rebron added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields QA/Yes labels Mar 15, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. needs-text-change This change requires some careful wording. labels Mar 15, 2022
@diracdeltas
Copy link
Member

diracdeltas commented Mar 15, 2022

there is a mini spec for this linked in https://bravesoftware.slack.com/archives/CD495CWLR/p1645642109975879?thread_ts=1644961566.418229&cid=CD495CWLR. the relevant section is below:

The “learn more” link points to https://support.google.com/chrome/answer/10468685?p=first_mode&visit_id=637806395632465747-627054495&rd=1#https-only-mode. At minimum we should have it go to a Brave support page instead.

We should also consider (1) redesigning the page to look less scary, especially if “Always use secure connections” is on by default and (2) adding a switch from the interstitial page to turn this feature off for {this session, until I turn it back on again}. Ryan's suggested copy is:

Header: [sitename.com] does not support HTTPS
Body: Brave tries to upgrade all sites from HTTP to a more secure HTTPS connection. In cases where a site doesn't support HTTPS, Brave will warn you before loading the page. Learn more.
CTAs: Proceed to site | Go back | Proceed & don't warn me again

We should make sure this interstitial page does NOT show up for Tor .onion sites since those have their own non-TLS encryption protocol and are thus “secure” (#1135).

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 15, 2022
@aguscruiz
Copy link

Adding the new design template for interstitials here:
https://www.figma.com/file/iiUbJmv6BaKwWctpysJNkU/Interstitial-screens?node-id=1%3A17

@rebron rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 28, 2023
@rebron rebron self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
Status: On Deck
Development

No branches or pull requests

3 participants