Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "not allowed state" to connection state #22061

Closed
Tracked by #15804
simonhong opened this issue Apr 4, 2022 · 0 comments · Fixed by brave/brave-core#12175
Closed
Tracked by #15804

Add "not allowed state" to connection state #22061

simonhong opened this issue Apr 4, 2022 · 0 comments · Fixed by brave/brave-core#12175
Assignees
@simonhong
Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Milestone
1.39.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Apr 4, 2022 •
edited
Loading

When vpn connection entry creation is denied by os or by user, it's notified as connection failed.
To give more detailed info for this situation, additional CONNECT_NOT_ALLOWED is needed.
@simonhong simonhong self-assigned this Apr 4, 2022
@simonhong simonhong mentioned this issue Apr 4, 2022
Merged
35 tasks
@bsclifton bsclifton mentioned this issue Apr 6, 2022
Closed
38 tasks
simonhong added a commit to brave/brave-core that referenced this issue Apr 6, 2022
@simonhong
Added missing failure state notifying on macOS
061d0b6 
Fixes brave/brave-browser#22061
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 9, 2022
@simonhong @bsclifton
Added missing failure state notifying on macOS
d30550f 
Fixes brave/brave-browser#22061
simonhong added a commit to brave/brave-core that referenced this issue Apr 11, 2022
@simonhong
Added missing failure state notifying on macOS
1ed6a4b 
Fixes brave/brave-browser#22061
@bsclifton bsclifton added this to the 1.39.x - Nightly milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Remaining Desktop VPN work brave/brave-core
2 participants
@bsclifton @simonhong