Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After restart, VPN status icon/button doesn't show connected status until clicked #22677

Closed
stephendonner opened this issue May 3, 2022 · 6 comments · Fixed by brave/brave-core#13505
Closed

After restart, VPN status icon/button doesn't show connected status until clicked #22677

stephendonner opened this issue May 3, 2022 · 6 comments · Fixed by brave/brave-core#13505
Assignees
@simonhong
Labels
bug feature/vpn OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.41.x - Release

Comments

@stephendonner
Copy link

Description

After restart, VPN status icon/button doesn't show connected status until clicked

Steps to Reproduce

  1. follow the steps to get an active VPN connection: https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
  2. once connected, disconnect from Brave VPN (either from Network Preferences or via Brave's VPN button toggle
  3. shut down Brave
  4. re-enable BraveVPN from the Network Preferences
  5. launch Brave
  6. look at the VPN button in the browser toolbar

Actual result:

Appears to not be connected (without clicking the VPN button explicitly)

restart-vpn-on

Expected result:

A single click on it shows the correct status.

Reproduces how often:

100%

Brave version (brave://version info)

cc @brave/qa-team @bsclifton @nullhook @simonhong
@stephendonner stephendonner mentioned this issue May 3, 2022
Closed
38 tasks
@simonhong
Copy link
Member

@stephendonner Thanks for catching. I think this came from last refactoring!

@simonhong simonhong self-assigned this May 4, 2022
@LaurenWags
Copy link
Member

++ reproduced. Good find @stephendonner 👍🏻

@LaurenWags LaurenWags mentioned this issue May 6, 2022
Closed
@stephendonner stephendonner mentioned this issue May 9, 2022
Closed
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 19, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 25, 2022 •
edited
Loading

++reproduced on windows 10 x64. Good catch indeed @stephendonner

@stephendonner
Copy link
Author

Maybe #23028 will help with this too.

simonhong added a commit to brave/brave-core that referenced this issue May 27, 2022
@simonhong
Check purchased state when service is launched
6febc9d 
Connection state is queried when purchased state is loaded and
it's purchased user.

fix brave/brave-browser#22677
fix brave/brave-browser#22726
fix brave/brave-browser#23080
@simonhong simonhong mentioned this issue May 27, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue May 30, 2022
@simonhong
Check purchased state when service is launched
deaa3aa 
Connection state is queried when purchased state is loaded and
it's purchased user.

fix brave/brave-browser#22677
fix brave/brave-browser#22726
fix brave/brave-browser#23080
@simonhong simonhong added this to the 1.41.x - Nightly milestone Jun 2, 2022
@stephendonner
Copy link
Author

stephendonner commented Jun 6, 2022 •
edited
Loading

Verified PASSED

Brave 1.41.37 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

Used my original steps to reproduce.

Steps:

  1. follow the steps to get an active VPN connection: https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
  2. once connected, disconnect from Brave VPN (either from Network Preferences or via Brave's VPN button toggle
  3. shut down Brave
  4. re-enable Brave VPN from macOS' Network Preferences
  5. launch Brave
  6. look at the VPN button in the browser toolbar

Confirmed Brave automatically toggled VPN status on the icon to show Connected, when relaunched after enabling VPN from Network Preferences

22677-image

@MadhaviSeelam
Copy link

Brave 1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 11 Version 21H2 (Build 22000.739)

Reproduced the issue in 1.40.70

Steps:

Followed above original steps for verification

Confirmed Brave automatically toggled VPN status on the icon to show Connected, when relaunched after enabling VPN from Network Preferences

2022-07-06_14h54_10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/vpn OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Check purchased state when service is launched brave/brave-core
6 participants
@stephendonner @rebron @simonhong @LaurenWags @GeetaSarvadnya @MadhaviSeelam