Hook Manage subscription link in Settings dialog up to the Accounts site

[stephendonner]

Description

Hook Manage subscription link in Settings dialog up to the accounts site

Steps to Reproduce

1. install 1.39.91
2. follow instructions to set up VPN: https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
3. click on the VPN button
4. click on the Settings (gears) button
5. click on Manage subscription

Actual result:

Nothing happens

example	example

Expected result:

IIRC it should go to (at least on development) https://account.brave.software/ (account.brave.com in prod)

Reproduces how often:

Brave version (brave://version info)

Brave	1.39.91 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision	67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS	macOS Version 11.6.5 (Build 20G527)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

cc @nullhook @bsclifton @brave/qa-team

[stephendonner]

Looks like we were going to include this as part of #18467 (comment) but have since punted, leaving Manage subscription pending; hence filing this issue 👍

[stephendonner]

I think @nullhook has a PR for this somewhere (hooking up the rest of the dialog UI, am I right?), but having explicit issues to verify individual changes is always good.

[stephendonner]

This is thrown in the console:

[15650:259:0505/184712.138182:ERROR:CONSOLE(29)] "Uncaught TypeError: Cannot read properties of undefined (reading 'create')", source: chrome-untrusted://vpn-panel.top-chrome/brave_vpn_panel.bundle.js (29)

[stephendonner]

@spylogsster looks like you already fixed this.

Was it fixed along with #22874?

[spylogsster]

fixed by brave/brave-core#13348

[stephendonner]

Verified PASSED using

Brave	1.41.55 Chromium: 102.0.5005.115 (Official Build) nightly (x86_64)
Revision	174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS	macOS Version 12.5 (Build 21G5037d)

Followed the steps to reproduce from #22694 (comment).

Confirmed clicking on Manage Subscription on the VPN dialog loads https://account.brave.software/account/, when using the development environment.

brave://flags	Manage Subscription link	https://account.brave.software/account/

[MadhaviSeelam]

Verification PASSED

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Followed the steps to reproduce from #22694 (comment).

Confirmed clicking on Manage Subscription on the VPN dialog loads https://account.brave.software/account/, when using the development environment.

Manage_Subscription	https://account.brave.software/account/