Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to initiate the sync chain between nightly and other channels #23428

Closed
GeetaSarvadnya opened this issue Jun 13, 2022 · 7 comments
Closed
Assignees

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 13, 2022

Description

Unable to initiate the sync chain between nightly and other channels

Steps to Reproduce

  1. Clean profile 1.41.59
  2. Open sync via the hamburger menu
  3. Click on Start a new sync chain
  4. Click on Computers
  5. Copy the sync code
  6. Open RC (1.39.x) or Beta or Dev
  7. Open sync via the hamburger menu
  8. Click on I have a sync code
  9. Paste the copied sync code
  10. Sync is NOT established between two devices, there is no error message in brave://sync-internals

Actual result:

Unable to initiate the sync chain between nightly and other channels

image

Expected result:

Should be able to sync devices with nightly

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.59 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @AlexeyBarabash @rebron @mkarolin

@stephendonner
Copy link

@GeetaSarvadnya see also #23206

@AlexeyBarabash
Copy link
Contributor

This happens because the PR brave/brave-core#12300
is in Nightly but not yet migrated to Beta/Stable.

Nightly uses time-limited sync code words, 25 words in phrase.
Beta and Stable - use old sync code words, 24 words.
Nightly can accept words from Beta/Stable, till August 2022. But Beta/Stable cannot accept words from Nightly.

A workaround:
If it is required to use codephrase from Nightly on Stable/Beta, it is possible to remove manually the last 25th word from the codephrase before entering the sync chain.

Marking as wont fix. Will close when time-limited codewords will reach Stable, July 12, 2022

@kjozwiak
Copy link
Member

@GeetaSarvadnya was re-opening the above an accident? Looks like it's labelled as closed/wontfix as per #23428 (comment). The above is expected until one-time sync codes get on all the channels. Currently it's only on 1.42.x & 1.41.x.

@GeetaSarvadnya
Copy link
Author

@kjozwiak I had closed it without seeing the last comment from @AlexeyBarabash Marking as wont fix. Will close when time-limited codewords will reach Stable, [July 12, 2022](https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates) after seeing the comments I have opened the issue again.

@kjozwiak
Copy link
Member

@AlexeyBarabash assuming the above isn't valid anymore? It's labelled as closed/wontfix. Can we close this off? If it's still an issue that needs to be addressed, we should remove the closed/wontfix label and re-triage. But I believe this is working as users have been syncing between different channels for some time now.

@AlexeyBarabash
Copy link
Contributor

@kjozwiak Sorry, I missed this discussion

Yes, it's good to close because the issue is not reproducible anymore
image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 13, 2023

@kjozwiak Sorry, I missed this discussion

Yes, it's good to close because the issue is not reproducible anymore

no worries! Thanks for taking a look/checking 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants