Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Your Brave Rewards is verified toast notification is not shown on the BR panel #23519

Closed
GeetaSarvadnya opened this issue Jun 16, 2022 · 4 comments
Assignees
Labels
bug closed/wontfix feature/rewards OS/Android Fixes related to Android browser functionality priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #22508
Your Brave Rewards is verified notification is not shown on the BR panel

Steps to reproduce

  1. Follow the steps from case 7 Implement error modal if user does not have receives OR sends capabilities on Uphold #22508 (comment)
  2. Click on the BR panel
  3. Your Brave Rewards is verified notification is not shown on the BR panel

Actual result

Your Brave Rewards is verified notification is not shown on the BR panel
Screenshot_20220616-224258_Brave

Expected result

image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tab A7
  • Android version: version 11

Brave version

1.40.101

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

CC: @brave/qa-team @Miyayes @deeppandya

@LaurenWags
Copy link
Member

duplicate of #9787

@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jun 22, 2022
@Miyayes Miyayes added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jul 7, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jul 18, 2022

My new solution is to remove these "you are now verified!" toast notifications completely.

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 18, 2022

@GeetaSarvadnya It doesn't show the toast notification for any of our custodians right? If so, then I will close this issue as wontfix, given this: #24114. Thanks!

@Miyayes Miyayes changed the title [Android] Your Brave Rewards is verified notification is not shown on the BR panel [Android] Your Brave Rewards is verified toast notification is not shown on the BR panel Jul 18, 2022
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 22, 2022

Gemini custodian linkage also I am not getting Your rewards is verified toast notification.

@Miyayes Looks like for all the 3 custodians we are not getting Your rewards is verified toast notification. Plese close the issue by linking #24114

Screenshot_20220722-111016_Brave

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2022
@Miyayes Miyayes closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/wontfix feature/rewards OS/Android Fixes related to Android browser functionality priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants