Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] "Your wallet is verified" notification does not display on Android #9787

Closed
LaurenWags opened this issue May 14, 2020 · 2 comments
Closed
Assignees
Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

On Desktop when your Uphold wallet becomes verified, you get a notification like the below:
verified-desktop

On Android, you get the red notification bubble, but when you tap on the BAT logo, there's no notification (similar to what happens with #9576).

Issues where this was implemented on desktop:
#5004 (comment)
#5874 (comment)

Steps to reproduce

  1. Using 1.10.x and staging, get an ad grant.
  2. Claim Ad grant.
  3. Tap on Verify Wallet.
  4. Start the wallet verification process (note, this is important, you cannot just connect an already verified/KYC'd Uphold account, you must start with one that is not KYC'd).
  5. Wait for verification (request from Uphold if necessary - lmk if you need instruction on this).
  6. Once you get confirmation verification has occurred, relaunch Brave.

Actual result

You will see a red notification bubble on BAT logo, but when you open panel, there's no notification.

Expected result

Should be a notification w/ text like desktop.

Issue reproduces how often

easily

Issue happens on

  • Current Play Store version? n/a
  • Beta build? yes, Nightly

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.10.22

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@LaurenWags LaurenWags added bug feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality ARM Android ARM related issues labels May 14, 2020
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 2, 2020
@LaurenWags
Copy link
Member Author

LaurenWags commented Jan 11, 2022

fyi @Miyayes this still occurs with 1.35.77 on Android. The expected design no longer matches what is in the issue but the notification still does not display even with the new panel work.

Also, the steps have changed slightly. Issue says:

Start the wallet verification process (note, this is important, you cannot just connect an already verified/KYC'd Uphold account, you must start with one that is not KYC'd).

This has changed, you can connect an already KYC'd account and you should still get this verified message (this is how it works on desktop at the moment).

@zenparsing zenparsing added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 26, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jun 22, 2022

Closing in favor of: #23519

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

6 participants
@deeppandya @zenparsing @anthonypkeane @Miyayes @LaurenWags and others