Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlimited ERC20 allowance is incorrectly displayed in transaction history #23562

Closed
onyb opened this issue Jun 21, 2022 · 1 comment · Fixed by brave/brave-core#13873
Closed

Unlimited ERC20 allowance is incorrectly displayed in transaction history #23562

onyb opened this issue Jun 21, 2022 · 1 comment · Fixed by brave/brave-core#13873
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release #3

Comments

@onyb
Copy link
Member

onyb commented Jun 21, 2022

Should display "Unlimited".
@onyb onyb added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 21, 2022
@onyb onyb self-assigned this Jun 21, 2022
@onyb onyb mentioned this issue Jun 21, 2022
Merged
25 tasks
@onyb onyb added the bug label Jun 21, 2022
@onyb onyb added this to the 1.42.x - Nightly milestone Jun 21, 2022
This was referenced Jun 21, 2022
Merged
Merged
@srirambv srirambv mentioned this issue Jun 24, 2022
Closed
@srirambv
Copy link
Contributor

Brave 1.40.107 Chromium: 103.0.5060.53 (Official Build) (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)

@kjozwiak kjozwiak mentioned this issue Jun 24, 2022
Closed
@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): fix formatting of unlimited token allowance brave/brave-core
3 participants
@kjozwiak @onyb @srirambv