Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up #23562] Unlimited ERC20 allowance shows full value in panel and on activity tab #23666

Closed
srirambv opened this issue Jun 24, 2022 · 1 comment · Fixed by brave/brave-core#17550

Comments

@srirambv
Copy link
Contributor

Description

[Follow up #23562] Unlimited ERC20 allowance shows full value in panel

Steps to Reproduce

  1. Activate a token for Swap
  2. Submit the transaction and keep the panel open
  3. Once tx is submitted, full value is shown instead of Unlimited

Actual result:

Unlimted.value.in.Panel.mp4

Expected result:

Should show Unlimited in panel as well similar to transaction history fixed as part of #23562

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.42.24 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb

@josheleonard josheleonard self-assigned this Mar 23, 2023
@HEagle18 HEagle18 changed the title [Follow up #23562] Unlimited ERC20 allowance shows full value in panel [Follow up #23562] Unlimited ERC20 allowance shows full value in panel and on activity tab Mar 23, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 24, 2023
@srirambv
Copy link
Contributor Author

srirambv commented May 2, 2023

Verification passed on

Brave 1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1555)
  • Verified steps from brave/brave-core#17550
  • Verified panel shows Unlimited instead of the max value for the token on the approval transaction
23666.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants