Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is different for QR Code and Code words #23948

Closed
srirambv opened this issue Jul 8, 2022 · 2 comments · Fixed by brave/brave-core#14095
Closed

Error message is different for QR Code and Code words #23948

srirambv opened this issue Jul 8, 2022 · 2 comments · Fixed by brave/brave-core#14095

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 8, 2022

Description

Error message is different for QR Code and Code words

Steps to reproduce

  1. Follow V. Case for too far in the future error test case from Time-limited sync words brave-core#12300 using two Android devices

Actual result

Error message for QR Code

This code is invalid. Please check that the time and timezone are set correctly on your device.

Error message for Code words

Sync could be setup [This code is invalid. Please check that the time and timezone are set correctly on your device.]

Expected result

Should be the same

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone/Tablet
  • Android version: 10/12

Brave version

1.41.94

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @AlexeyBarabash @brave/legacy_qa

@srirambv srirambv added bug l10n feature/sync QA/Yes OS/Android Fixes related to Android browser functionality labels Jul 8, 2022
@AlexeyBarabash AlexeyBarabash self-assigned this Jul 8, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Jul 8, 2022

Also need to fix this screen to say Wrong sync code
image

AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jul 8, 2022
Now errors produced by join via QR and via sync words are the similar

fixes brave/brave-browser#23948
@AlexeyBarabash AlexeyBarabash added this to the 1.43.x - Nightly milestone Jul 8, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.43.74, Chromium 104.0.5112.102 on a Google Pixel XL, running Android 9.

Steps:

  1. Created sync chain on new desktop version, 25 words.
  2. Adjusted time on Android device 2 days backwards;
  3. Connected Android to chain via words

Confirmed I got "Sync could not be setup [This code is invalid. Please check that the time and timezone are set correctly on your device.]" error message

2 days ago Sync chain error message
Screenshot_20220629-175307 Screen Shot 2022-08-18 at 9 43 05 AM Screenshot_20220627-175407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants