Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Wallet Payment ID to Rewards Payment ID #24017

Closed
Miyayes opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#14183
Closed

Rename Wallet Payment ID to Rewards Payment ID #24017

Miyayes opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#14183
Assignees

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 12, 2022

Description

Replace all instances of "Wallet Payment ID" with "Rewards Payment ID" in visible contexts, such as brave://rewards-internals.

cc: @brave/user-support-team

@stephendonner
Copy link

stephendonner commented Aug 3, 2022

Verified PASSED using

Brave 1.43.56 Chromium: 104.0.5112.81 (Official Build) dev (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Steps:

  1. installed 1.43.56
  2. launched Brave
  3. enabled Rewards
  4. opened brave://rewards-internals

Confirmed the following string changes:

  • Wallet info -> Rewards info
  • Wallet payment ID -> Rewards payment ID
  • Wallet created at -> Rewards profile created at
1.43.56 1.42.86
Screen Shot 2022-08-03 at 11 09 16 AM Screen Shot 2022-08-03 at 11 09 40 AM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.43.58 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.795)
  1. installed 1.43.58
  2. launched Brave
  3. enabled Rewards
  4. opened brave://rewards-internals

Confirmed the following string changes:

  • Wallet info -> Rewards info
  • Wallet payment ID -> Rewards payment ID
  • Wallet created at -> Rewards profile created at
  • Wallet status -> Rewards state
1.42.86 1.43.58
image image

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 & Samsung Galaxy Tab S7 using

Brave	1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit) 
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Android 12; Build/SP1A.210812.016
  • Confirmed the following string changes in the brave://rewards-internals under General info (Replacing "Wallet" with "Rewards")

  • Wallet info -> Rewards info

  • Wallet payment ID -> Rewards payment ID

  • Wallet created at -> Rewards profile created at

  • Wallet status -> Rewards state

Mobile Tablet
screenshot-1660862361410 screenshot-1660862577405
1.42.x (Mobile) 1.42.x (Tablet)
screenshot-1660862882096 screenshot-1660862865221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants