Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bridge to Aurora button on asset detail screen #24446

Closed
jamesmudgett opened this issue Aug 4, 2022 · 4 comments · Fixed by brave/brave-core#14556
Closed

Add Bridge to Aurora button on asset detail screen #24446

jamesmudgett opened this issue Aug 4, 2022 · 4 comments · Fixed by brave/brave-core#14556
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.43.x - Release #4

Comments

@jamesmudgett
Copy link

jamesmudgett commented Aug 4, 2022 •
edited
Loading

Android version of #24377

Add "Bridge to Aurora" button on all supported assets (this screen shows all supported assets including both highlighted and not highlighted)

Image

Example placement

Image

First time tapping on bridge button

Image

(Lets show a system dialog that informs the user of the risks, the learn more button should be a system button and not a link in the message body. Three buttons [Continue, Cancel, Learn more], learn more link https://ethereum.org/en/bridges/#bridge-risk)
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 4, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 4, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 9, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 25, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 26, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2022

The above will require 1.44.72 or higher for 1.42.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2022

Verification passed on the following devices running 1.44.75 x64 build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
24446-ARM.mp4
24446-Tab.mp4

@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 8, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2022

Removing the QA/Pass labels as this was uplifted into 1.43.x so we'll need to recheck it quickly. The above requires 1.43.92 or higher for 1.43.x verification.

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.43.92 x64 build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
24446-ARM.mp4
24446-Tab.mp4

@srirambv srirambv mentioned this issue Sep 12, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release #4
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement aurora bridge button brave/brave-core
5 participants
@jamesmudgett @kjozwiak @Pavneet-Sing @srirambv @brave-builds