Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when switching/selecting networks and quickly viewing asset details #25131

Closed
srirambv opened this issue Sep 1, 2022 · 2 comments · Fixed by brave/brave-core#14944
Closed

Browser crash when switching/selecting networks and quickly viewing asset details #25131

srirambv opened this issue Sep 1, 2022 · 2 comments · Fixed by brave/brave-core#14944
Assignees
@Pavneet-Sing
Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support intermittent-issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 1, 2022 •
edited by Pavneet-Sing
Loading

Description

Found while testing brave/brave-core#14556, Browser crash when selecting Testnet ETH

Steps to reproduce

  1. Create wallet
  2. Select Ethereum Mainnet and select ETH
  3. Go back to wallet and quickly select Testnet and select ETH, browser crashes and reloads

Actual result

Crash.when.Testnet.ETH.selected.mp4

Crash Log:

  1. https://share.backtrace.io/api/share/N3CorV5CwE7Wx2dMN0dwYs2
  2. https://share.backtrace.io/api/share/Fa17mFIgzfWwatomvWHB73
  3. https://share.backtrace.io/api/share/fR9zx26zTSdg3Ayw0GC3ll2

Expected result

No crash

Issue reproduces how often

Only once on first attempt. Subsequent doesn't cause crash

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.45.18

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @SergeyZhukovsky
@srirambv srirambv added bug crash intermittent-issue QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Sep 1, 2022
@srirambv srirambv mentioned this issue Sep 1, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing changed the title Browser crash when selecting Testnet ETH Browser crash when switching/selecting networks and quickly viewing asset details Sep 1, 2022
@Pavneet-Sing
Copy link

Updated the details, it's linked with clicking on an old asset which is yet to be updated for the changed network. (asset list takes some time to update)

@Pavneet-Sing Pavneet-Sing self-assigned this Sep 1, 2022
@Pavneet-Sing Pavneet-Sing added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 1, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 1, 2022
Merged
25 tasks
@srirambv srirambv mentioned this issue Sep 6, 2022
Closed
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 12, 2022
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 12 running 1.45.88 x64 build

  • Verified steps from issue description & brave/brave-core#14944
  • Verified no crash when switching network and selecting an asset
  • Verified when network is changed there is small delay in loading the asset

Verification passed on Samsung Tab A with Android 10 running 1.45.88 x64 build

  • Verified steps from issue description & brave/brave-core#14944
  • Verified no crash when switching network and selecting an asset
  • Verified when network is changed there is small delay in loading the asset

@kjozwiak kjozwiak mentioned this issue Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support intermittent-issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): crash on old network asset click and fix aurora link formatting brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds