Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Find extensions and Themes text #2497

Closed
rebron opened this issue Dec 12, 2018 · 5 comments · Fixed by brave/brave-core#1080
Closed

change Find extensions and Themes text #2497

rebron opened this issue Dec 12, 2018 · 5 comments · Fixed by brave/brave-core#1080
Assignees
@mkarolin
Labels
feature/extensions polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 12, 2018

cws

Text shouldn't say "Brave Web Store" until ours launches.
@rebron rebron added feature/extensions polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 12, 2018
@rebron
Copy link
Collaborator Author

rebron commented Dec 12, 2018

cc: @bradleyrichter @tomlowenthal

Suggested text as provided by toml:
"You don't have any extensions yet. Would you like to [install some](cws link)?"

@rebron
Copy link
Collaborator Author

rebron commented Dec 12, 2018 •
edited
Loading

We should also have text when Extensions are installed and this page isn't empty to point to CWS store for now. Centered and under the list of extensions at the bottom.

"Looking for even more extensions?" with this whole line as link to CWS store.

@rebron rebron added this to the 0.58.x - Release milestone Dec 12, 2018
@mkarolin mkarolin mentioned this issue Dec 13, 2018
Merged
18 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
64ef8e8 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
@srirambv srirambv mentioned this issue Dec 13, 2018
Closed
@srirambv
Copy link
Contributor

@mkarolin would this fix #1013 as well?

@mkarolin
Copy link
Contributor

@srirambv, I'll pull that into the fix.

mkarolin added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
884612c 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
@rebron rebron removed this from the 0.58.x - Release milestone Dec 13, 2018
mkarolin added a commit to brave/brave-core that referenced this issue Dec 14, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
d490716 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
@mkarolin mkarolin mentioned this issue Dec 18, 2018
Closed
@eljuno eljuno mentioned this issue Dec 20, 2018
Closed
mkarolin added a commit to brave/brave-core that referenced this issue Dec 25, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
7d3a0f9 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 2, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Jan 7, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
8eb4a05 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Jan 8, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
1f89663 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Jan 8, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
655f19c 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
This was referenced Jan 8, 2019
Merged
Merged
@mkarolin mkarolin modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 10, 2019
This was referenced Jan 16, 2019
Closed
Closed
@btlechowski
Copy link

btlechowski commented Jan 18, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 10 05 45 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/extensions polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Change link text on extensions page. brave/brave-core
6 participants
@rebron @NejcZdovc @srirambv @LaurenWags @btlechowski @mkarolin