NTP Stats Toggle is Broken

[fallaciousreasoning]

Description

The stats toggle in the customise NTP doesn't update. You can still use it to reshow the stats, and hide them via the 3 dot menu but the toggle isn't working properly.

[stephendonner]

Confirmed using

Brave	1.44.60 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision	5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS	macOS Version 13.0 (Build 22A5321d)

Steps:

1. install 1.44.60
2. launch Brave
3. open a new tab/window
4. click on Customize on the lower right
5. click on Brave Stats
6. look at the Show Brave Stats button

Actual:

It's disabled

Expected:

It should be on/off toggleable (sp!)

[stephendonner]

Also broken in

Brave	1.45.1 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision	5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS	macOS Version 13.0 (Build 22A5321d)

[stephendonner]

Verified PASSED using

Brave	1.45.21 Chromium: 105.0.5195.68 (Official Build) nightly (x86_64)
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	macOS Version 13.0 (Build 22A5331f)

Steps:

1. launch Brave
2. open a new tab/window
3. click on Customize on the lower right
4. click on Brave Stats
5. look at the Show Brave Stats button
6. toggle it Off
7. toggle it On

Confirmed Off / On state correlated with stats dashboard

toggled Off	toggled On

[kjozwiak]

Removed the QA Pass-macOS as this will need to be rechecked on 1.44.x once we get RC builds. I also added release-notes/include as this ended up making it into 1.44.x. Hence, adding it into the 1.44.x maintenance release.

@stephendonner also double checked that the above was fixed with the latest 1.45.x via #25663 (comment) which we used to uplift this into 1.44.x.

[kjozwiak]

The above requires 1.44.108 or higher for 1.44.x verification. Just a note that DevOps kicked off a 1.44.107 for noplatforms so there was never any platforms builds for that version.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.44.108 Chromium: 106.0.5249.103 (Official Build) (64-bit)
-- | --
Revision | 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS | Windows 10 Version 21H2 (Build 19044.2006)

• Reproduced the issue in 1.44.101 , 1.44.103 and 1.44.105
• Upgraded the profile to 1.44.108 and ensured Show Brave Stats button can be toggled on/off

Example	Example	Example	Example	Example	Example