Show Brave Stats toggle broken

[cdes5804]

Description

"Show Brave Stats" toggle is broken and the browser won't turn it off.

Steps to Reproduce

1. Open "New Tab".
2. Click on "Show Brave Stats" switch in Customize Dashboard setting.

Actual result:

Screen.Recording.2022-09-28.at.10.06.01.AM.mov

Expected result:

Show be able to turn off display of brave stats.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (x86_64)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[stephendonner]

Confirmed in

Brave	1.44.101 Chromium: 106.0.5249.65 (Official Build) (x86_64)
Revision	3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	macOS Version 11.7 (Build 20G817)

This is working in

Brave	1.46.15 Chromium: 106.0.5249.65 (Official Build) nightly (x86_64)
Revision	3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	macOS Version 11.7 (Build 20G817)

cc @sangwoo108 - is there an uplift we need to take in the next maintenance release/hotfix?

[stephendonner]

Looks like we need #24985

cc @fallaciousreasoning @rebron

[fallaciousreasoning]

I've created the uplift pr, and requested an uplift 😄

[kjozwiak]

Closing the above as this has been fixed via brave/brave-core#14839 and will be uplifted into 1.44.x via brave/brave-core#15264.

[stephendonner]

Verified PASSED using

Brave	1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (x86_64)
Revision	fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS	macOS Version 11.7 (Build 20G817)

Steps:

1. install 1.45.87
2. launched Brave
3. clicked on Skip welcome tour
4. clicked Customize
5. clicked Brave Stats
6. confirmed Show Brave Stats was toggled to Enabled / On and confirmed stats on the page
7. toggled Show Brave Stats to Disabled/ Off, and confirmed stats disappear
8. toggled back On
9. also context-clicked the 3 vertical dots and chose Hide Brave Stats and confirmed they disappeared

step 6	step 7	step 8	step 9a	step 9b

[kjozwiak]

Thanks for checking the above @stephendonner 👍 I'm going to close this off as a QA/No but I'll move it into 1.44.x once we uplift via brave/brave-core#15264. We'll use #24985 as the main issue for verification on 1.44.x.