Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 105.0.5195.58 to Chromium 105.0.5195.68 #25009

Closed
mkarolin opened this issue Aug 26, 2022 · 5 comments · Fixed by brave/brave-core#14854
Closed

Upgrade from Chromium 105.0.5195.58 to Chromium 105.0.5195.68 #25009

mkarolin opened this issue Aug 26, 2022 · 5 comments · Fixed by brave/brave-core#14854

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/105.0.5195.58..105.0.5195.68?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:
No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

We'll still need to run through the affected area's mentioned via #23800 (comment) on Linux and macOS as the other platforms have already been checked per the below:

@MadhaviSeelam
Copy link

Verification PASSED using

Brave 1.43.83 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Windows 11 Version 21H2 (Build 22000.856)

image

@stephendonner
Copy link

stephendonner commented Aug 29, 2022

Verification PASSED using

Brave 1.43.83 Chromium: 105.0.5195.68 (Official Build) (x86_64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 13.0 (Build 22A5331f)

Screenshot 2022-08-29 at 12 17 56 PM

Settings UI: search engines show correctly - PASSED
en-US France India
Screenshot 2022-08-29 at 12 55 32 PM Capture d’écran 2022-08-29 à 13 20 57 स्क्रीनशॉट 2022-08-29, अ 1 15 40 पर
Wallet importer - covered by Sri?
Color scheme (omnibox, sidebar, private/tor windows) - PASSED
omnibox (Light) omnibox (Dark) sidebar Private window Private w/Tor Guest
Screenshot 2022-08-29 at 12 45 07 PM Screenshot 2022-08-29 at 12 46 06 PM Screenshot 2022-08-29 at 12 53 18 PM Screenshot 2022-08-29 at 12 42 52 PM Screenshot 2022-08-29 at 12 42 57 PM Screenshot 2022-08-29 at 12 43 03 PM
Brave News (overall looks correctly - related to JSON parsing changes) - PASSED example | example | example ---------|----------|--------- Screenshot 2022-08-29 at 1 46 18 PM | Screenshot 2022-08-29 at 1 46 21 PM | Screenshot 2022-08-29 at 1 48 48 PM
Brave wallet (overall looks and operates correctly - related to JSON parsing changes) - covered by Sri?
Brave VPN (overall looks correctly - related to JSON parsing changes) - UNAVAILABLE in 1.43
Settings UI: privacy page looks correctly - PASSED Screenshot 2022-08-29 at 1 31 01 PM
Bookmarks, History, Extensions pages style looks correctly - PASSED
bookmarks history extensions
Screenshot 2022-08-29 at 1 36 47 PM Screenshot 2022-08-29 at 1 38 17 PM Screenshot 2022-08-29 at 1 40 01 PM
Brave features' text labels look correct when running the browser in a different language - PASSED
example example example
Captura de pantalla 2022-08-29 a las 14 06 27 Captura de pantalla 2022-08-29 a las 14 14 29 Captura de pantalla 2022-08-29 a las 14 16 07
Upgrade in different channels works correctly - PASSED CR104` (1.43.79, beta)-> CR105 (1.43.83, release candidate)
1.43.79 1.43.83
Screenshot 2022-08-29 at 2 51 32 PM Screenshot 2022-08-29 at 2 51 55 PM
App menu, page context menu, sidebar context menu look correctly - PASSED
app menu page context menu sidebar context menu
Screenshot 2022-08-29 at 2 25 07 PM Screenshot 2022-08-29 at 2 22 51 PM Screenshot 2022-08-29 at 2 24 05 PM

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 29, 2022
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 devices using the following build version(s):

Brave	1.43.83 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016
  • Version bump
  • Branding
  • NTP/Settings Menu
  • Spot checked some data on upgraded profile
Example Example Example
screenshot-1661801723800 screenshot-1661802572737 screenshot-1661802594044

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 29, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.43.83 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Ubuntu 18.04 LTS

image

Settings UI: search engines show correctly - PASSED

image

Color scheme (omnibox, sidebar, private/tor windows) - PASSED

image
image
image
image

Brave News (overall looks correctly - related to JSON parsing changes) - PASSED

image

Settings UI: privacy page looks correctly - PASSED

image

Bookmarks, History, Extensions pages style looks correctly - PASSED

image
image
image

Brave features' text labels look correct when running the browser in a different language - PASSED

image
image
image

App menu, page context menu, sidebar context menu look correctly - PASSED

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment