Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 104 to Chromium 105. #23800

Closed
mkarolin opened this issue Jun 30, 2022 · 5 comments · Fixed by brave/brave-core#13946
Closed

Upgrade from Chromium 104 to Chromium 105. #23800

mkarolin opened this issue Jun 30, 2022 · 5 comments · Fixed by brave/brave-core#13946

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jun 30, 2022

Upgrade from Chromium 104 to Chromium 105.

https://chromium.googlesource.com/chromium/src/+log/104.0.5112.81..105.0.5195.10/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Settings UI: search engines show correctly
  • Wallet importer
  • Color scheme (omnibox, sidebar, private/tor windows)
  • Brave Today (overall looks correctly - related to JSON parsing changes)
  • Brave wallet (overall looks and operates correctly - related to JSON parsing changes)
  • Brave VPN (overall looks correctly - related to JSON parsing changes)
  • Settings UI: privacy page looks correctly
  • Bookmarks, History, Extensions pages style looks correctly
  • Brave features' text labels look correctly when running the browser in a different language
  • Upgrade in different channels works correctly
  • App menu, page context menu, side bar context menu look correctly

iOS

  • URL spoofing

Android Affected areas:

  • Autocomplete and suggestions
  • Background video playback
  • NTP layout
  • Site settings icons
  • Site settings close button
@stephendonner
Copy link

stephendonner commented Aug 24, 2022

Verification PASSED for my portion, below using

Brave 1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Windows 10 Version 21H2 (Build 19044.1889)
Settings UI: search engines show correctly - PASSED
  • Defaults {en-US}
  • Defaults {other locales}
  • Search engine list same as release
  • Change and verify reflects in normal/private windows

en-US

Defaults

1.44.64 release (Brave)
search-engine-defaults release

brave://settings/searchEngines

1.44.64 release (Brave)
image searchEngines-1-42-97

Other locales (Google)

India Ireland Poland
োো Ireland Polish
Wallet importer * Seed `release` (using test faucet?) and verify import works (?)
Color scheme (omnibox, sidebar, private/Tor windows) - PASSED
  • Omnibox
  • Sidebar
  • Private window
  • Private window w/Tor
  • Guest window
omnibox sidebar
omnibox bookmarks-sidebar
Private window Private window w/Tor Guest window
private-window brave-tor-success guest-window
Brave News (overall looks correctly - related to JSON-parsing changes) - PASSED
example example example example
brave-news-disclaimer brave-news-ad brave-news-custom-feed-add brave-news
Brave Wallet (overall looks and operates correctly - related to JSON-parsing changes)
Brave VPN (overall looks correctly - related to JSON-parsing changes) - PASSED
example example example example example
VPN-1 VPN-2 VPN-3 VPN-4 VPN-5png

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 24, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 24, 2022

Verification PASSED on

Brave | 1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
-- | --
Revision | 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Settings UI: privacy page looks correctly_PASSED
  • Encountered the icons missing or expand arrow or other icons (e.g seach etc) are missing in almost all the pages in each settings, posted the screenshots in Missing icons in brave://settings and advanced settings pages #24872 (comment)
  • Verified the each settings in privacy page and ensured each settings works as expected
  • Verified that the new section Tor windows is been added in brave://settings/privacy page
  • Verified that the settings Private window with Tor and Automatically redirect .onion sites works as expected
Bookmarks, History, Extensions pages style looks correctly_PASSED
Bookmarks_PASSED
  • Logged Blue check mark icon is missing in Import bookmarks and settings page #24944
  • Verified bookmarks cab be imported via NTP, brave://settings/importData, import bookmarks option via Hamburger menu and boomarks manager page
  • Verified that bookmarks folder shape/style is as per the brave specifications
  • Verified bookmarks can be imported from various browser (chrome, FF, Edge and Opera)
  • Verified boomarks can be added/edited/deleted
  • Verified bookamrks can be opened by clicking on the bookmarked pages
  • Verified passwords, history, autofill settings and history details are imported successfully
    image
Extensions_PASSED
  • Verified that Private window with Tor and Automatically redirect .onion sites settings are moved from brave://settings/extensions page
  • Verified that brave://settings/extensions page style and content looks as expected
  • Verified that click on each settings in extension page redirected to intended pages
  • Verified that click on Manage extensions redirects to brave://extensions/ where installed extensions are listed
  • Click on Details on the installed extension and enabled Allow in private switch and ensured that the extesion is shown in PT and TOR windows
Example Example
image image
History_PASSED
  • Verified that after viewing the couple of websites browser history is collected in brave://history
  • Verified that browser history can be imported from other browser
  • Verified browser history, cookies, passwords can be removed
Brave features' text labels look correctly when running the browser in a different language_PASSED
  • Ensured text and labels look correctly in other locales (verified in Kannada my mother tongue :) )
Example Example Example Example Example
image image image image image
Upgrade in different channels works correctly_PASSED
  • Ensured that upgrade from CR104 to CR105 looks good
App menu, page context menu, side bar context menu look correctly_PASSED
App menu_PASSED
  • Icons are missing the Guest window brave://settings/help page enountered the issue Missing icons in brave://settings and advanced settings pages #24872
  • Verified that App menu settings are working as expected
  • Verified that click on App menu settings redirected to intended pages in normal window
  • Verified that click on App menu settings redirected to intended pages in private window
  • Verified that click on App menu settings redirected to intended pages in tor window
  • Verified that click on App menu settings redirected to intended pages in guest window
Example Example Example Example
image image image image
Page context menu_PASSED
  • encountered and logged Brave crashes upon closing the Private window #24953
  • Verified context menu items are shown correctly when right click on any link in a webpage
  • Verified context menu items are shown correctly when right click on any image in a webpage
  • Verified that click on each context menu items redirected to the intended pages
Example Example
image image
Sidebar context menu_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, logged Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
Example Example Example Example Example
image image image image image

Settings comparison

  • Verified that the Language settings are updated as part of CR 105
    image
  • Verified that the new settings Tab hover mode and side panel are added in brave://settings/appearance as part of brave
    image
  • Verified that Solid colors settings is been added in Dashboard Settings in NTP
    image
  • Verified that the settings Private window with Tor and Automatically redirect .onion sites are moved to new section Tor windows and which is present inside the brave://settings/privacy settings section
  • Ensured that the settings Private window with Tor and Automatically redirect .onion sites works as expected
    image
  • Verified Use Bridges new settings in been added in the new section Tor windows

Components updater

  • No new components are added as part of CR 105
  • Components are updates successfully without any error
  • New component Brave Ads Resources (en) is been added as part of brave
    image
1.44.64 Chromium: 105.0.5195.37 1.42.97 Chromium: 104.0.5112.102
image image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.2 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Linux

Wallet importer

  • Verified able to import a wallet using seed word(12 words/24words)
  • Verified able to import a Ethereum account using private key
  • Verified able to import a Ethereum account via Ledger & Trezor
  • Verified able to import a Solana account via Ledger
  • Verified able to import a Solana account via Private key
  • Verified able to import a Filecoin account via Ledger
  • Verified able to import a Filecoin account via Private key
  • Verified able to import wallet from MetaMask
  • Verified able to import wallet from Crypto Wallet Extensions

Brave wallet (overall looks and operates correctly - related to JSON parsing changes)

  • Verified Brave Wallet looks good

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 25, 2022

Verified on Samsung Galaxy S21 & Samsung G-Tab S7 running Android 12 using build version:

Brave	1.45.1 Chromium: 105.0.5195.37 (Official Build) canary (64-bit) 
Revision	5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS	Android 12; Build/SP1A.210812.016

Spot checked the following areas:

  • Autocomplete and suggestions
  • Background video playback
  • NTP layout
  • Site settings icons
  • Site settings close button
Example Example
screenshot-1661445950499 screenshot-1661446264695

@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #24948. As per #24948 (comment), Linux still needs to run through the affected areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment