Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Customize sidebar has some style issues #26560

Closed
petemill opened this issue Nov 4, 2022 · 3 comments · Fixed by brave/brave-core#15814
Closed

Brave News Customize sidebar has some style issues #26560

petemill opened this issue Nov 4, 2022 · 3 comments · Fixed by brave/brave-core#15814

Comments

@petemill
Copy link
Member

petemill commented Nov 4, 2022

  • Channels don't have icons
  • Grid spacing is too much
  • Font family is incorrect in some places
  • Sources list title is too bold
  • Long source names are not wrapping correctly

image

@stephendonner
Copy link

@petemill can you also include #26293, if not already?

@kjozwiak
Copy link
Member

The above requires 1.46.107 or higher for 1.46.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.122 Chromium: 108.0.5359.48 (Official Build) beta (x86_64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 11.7.1 (Build 20G918)

Ensured:

  • channels have icons
  • CSS-grid spacing flexes better
  • improved font-family usage
  • reduced Sources title boldness
  • better wrapping of long source names

UI

Light Dark
Screen Shot 2022-11-21 at 8 46 35 PM Screen Shot 2022-11-21 at 8 47 33 PM

Channels

Light Dark
Screen Shot 2022-11-21 at 8 48 49 PM Screen Shot 2022-11-21 at 8 48 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants