Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font color for onboarding v2 for dark theme is too light for import screens #27105

Closed
rebron opened this issue Dec 1, 2022 · 5 comments · Fixed by brave/brave-core#16164
Closed
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 1, 2022

Description

Text isn't legible for two of the import screens for onboarding v2 in dark theme.

Steps to Reproduce

  1. Use 1.47.x or 1.48.x
  2. Go to brave://welcome and go to Import screen screens.
  3. Text isn't legilble and font color should be darker

Actual result:

Screenshot 2022-12-01 at 3 40 28 PM

Screenshot 2022-12-01 at 3 40 14 PM

Expected result:

Screenshot 2022-12-01 at 3 42 22 PM

Screenshot 2022-12-01 at 3 42 15 PM

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. onboarding Front-end related to helping a new user learn about features within the browser. QA/Yes release-notes/exclude labels Dec 1, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 9, 2022
@kjozwiak
Copy link
Member

The above requires 1.47.131 or higher for 1.47.x verification 👍

@btlechowski
Copy link

Verification passed on

Brave 1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Light theme
image
image

Dark theme
image
image

@stephendonner
Copy link

As I saw this on macOS too, marking QA/Test-All-Platforms so it can be verified there, also.

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.149 Chromium: 109.0.5414.46 (Official Build) beta (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS macOS Version 11.7.2 (Build 20G1020)

Followed the steps to reproduce as filed.

Confirmed the text throughout the onboarding screens was legible for both Dark and Light modes

Dark

Import Settings Select profile to import Setup complete
Screen Shot 2022-12-28 at 10 35 07 AM Screen Shot 2022-12-28 at 10 42 15 AM Screen Shot 2022-12-28 at 10 52 34 AM

Light

Import Settings Select profile to import Setup complete
Screen Shot 2022-12-28 at 10 42 53 AM Screen Shot 2022-12-28 at 10 42 35 AM Screen Shot 2022-12-28 at 10 45 31 AM

@MadhaviSeelam
Copy link

Verification PASSED

Brave | 1.47.149 Chromium: 109.0.5414.46 (Official Build) beta (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 22H2 (Build 22621.963)

Verified from STR from the description - #27105 (comment)

Confirmed the text throughout the onboarding screens was legible for both Dark and Light modes

Dark

ex1 ex2 ex3
image mage image

Light:

ex1 ex2 ex3
image image image

@stephendonner stephendonner changed the title Font color for onboardingv2 for dark theme is too light for import screens Font color for onboarding v2 for dark theme is too light for import screens Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants