Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "ShareHubIcon" on internal pages #27484

Closed
jagadeshjai opened this issue Dec 21, 2022 · 2 comments · Fixed by brave/brave-core#16505
Closed

Remove "ShareHubIcon" on internal pages #27484

jagadeshjai opened this issue Dec 21, 2022 · 2 comments · Fixed by brave/brave-core#16505

Comments

@jagadeshjai
Copy link

Description

"ShareHubIcon" in the omnibox copies link with "chrome" scheme instead of "brave".

Steps to Reproduce

  1. Open New tab
  2. Click "Share" icon in the location bar.
  3. Click "Copy link" and paste the link.

Actual result:

image

After pasting the copied link.

image

Expected result:

  1. As the share icon is rarely used in internal pages, it can be removed. (or)
  2. Link should be changed to "brave" scheme.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave : 1.46.144 Chromium: 108.0.5359.128 (Official Build) (64-bit)
Revision : 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS : Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Its not a issue for chrome.

Miscellaneous Information:

@rebron rebron added branding priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/include labels Dec 22, 2022
jagadeshjai added a commit to jagadeshjai/brave-core that referenced this issue Dec 31, 2022
As "ShareHubIcon" in the omnibox copies link with "chrome" scheme instead of "brave" and due to the rare usage on internal pages.

fixes brave/brave-browser#27484
@goodov
Copy link
Member

goodov commented Mar 13, 2023

@rebron are we okay with removing this button on internal pages?

@rebron rebron added this to the 1.51.x - Beta milestone Mar 29, 2023
@rebron rebron changed the title "ShareHubIcon" in the omnibox copies link with "chrome" scheme instead of "brave". Remove "ShareHubIcon" on internal pages Mar 29, 2023
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 29, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.51.76 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2788)

Steps to Reproduce:

  1. installed 1.51.76
  2. launched Brave
  3. opened brave://settings/help
  4. confirmed no Share icon in the URL bar
  5. also opened brave://version and confirmed the same
  6. lastly, loaded nbcnews.com and clicked the URL bar
  7. confirmed the Share icon was present and working
brave://settings/help brave://version nbcnews.com/now Share icon
image image image (3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants