Extensions import broken

[spylogsster]

Description

Trying to import extensions from other browsers and it doesnt work

Steps to Reproduce

1. go to chrome://settings/importData
2. Import extensions from other browser

Actual result:

Extensions not imported

Expected result:

Extensions imported

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[MadhaviSeelam]

++
Reproduced this issue in

Brave | 1.47.139 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 22H2 (Build 22621.963)

[stephendonner]

Should this be reopened, @rebron @spylogsster ?

[spylogsster]

@MadhaviSeelam mentioned 1.47. the uplift is opened brave/brave-core#16454 to 1.47. cc @stephendonner @rebron

[kjozwiak]

The above requires 1.47.155 or higher for 1.47.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (x86_64)
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	macOS Version 11.7.2 (Build 20G1020)

Prerequisites:

1. install all the various browsers
2. launch any of them
3. for each, download and install at least two (2) or more extensions
4. confirm the extensions installed correctly via the correct scheme handler, e.g. edge://extensions, chrome://extensions, vivaldi://extensions, etc.
5. run through the following Shared Steps, for each browser
6. repeat

Shared Steps

1. install 1.47.161
2. launch Brave
3. open brave://settings/importData
4. confirm and choose the respective browser profile
5. choose Import
6. wait until extensions are finished opening new tabs/changing settings, etc.
7. click on Done
8. open brave://extensions
9. confirm the original extensions from the non-Brave browser have been imported successfully into Brave

Case 1: Chrome - PASSED

Chrome	example	example	example	example

Case 2: Chrome Beta - PASSED

Chrome Beta	example	example	example	example

Case 3: Chrome Dev - PASSED

Chrome Dev	example	example	example	example

Case 4: Chrome Canary - PASSED

Chrome Canary	example	example	example	example

Case 5: Microsoft Edge - PASSED

Edge	example	example	example	example

Case 6: Opera - FAILED

Opera	example	example	example	example

Case 7: Vivaldi - PASSED

Vivaldi	example	example	example	example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Note: Currently import of extensions from Opera is not supported. @rebron to file a follow up issue.

Case 1: Import Extensions via onboarding from Chrome - brave://welcome - PASSED

Prerequisite: Install Chrome browser with 1Password extension

1. Install 1.47.161
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import button
6. check Chrome Person 1
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extension is successfully imported and shown in brave://extensions

step 3	step 4	step 5-6	step 8	step 10	step 11

Case 2: Import Extensions via onboarding from Chrome Canary - brave://welcome - PASSED

Prerequisite: Install Chrome Canary browser
Person 1: Snowflake extension and Bookmarks
Person 2: Bookmarks only

1. new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome Canary
5. click Import
6. click Select All
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extension is successfully imported along with bookmarks and is shown in brave://extensions

step 3	step 4-5	step 6-7	step 9	step 10	step 11

Case 3: Import Extensions from Edge - brave://welcome - PASSED

Prerequisite: Install Edge with extensions, bookmarks, saved passwords
Profile 2: bookmarks, saved passwords & extensions (Nimbus)
Profile 3: bookmarks, extensions (Google translate)

1. new profile
2. launch Brave
3. Skip Set Brave as default browser button
4. select Microsoft Edge
5. click Import
6. select Profile 1 & Profile 2
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions along with bookmarks from both profiles are successfully imported

step 3	step 4-5	step 6-7	step 8	step 10	step 11

Case 4: Import Extensions from Chrome Dev - brave://welcome- PASSED

Profile 1: 2 Extensions (Color zilla, Tiny sketch)
Profile 2: No data (No extensions)

1.new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import
6. check Chrome Dev Person 1 and Chrome Person 2
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions are successfully imported and are shown in brave://extensions

step 3	step 4-5	step 6-7	step 9	step 10	step 11

Case 5: Import Extensions from Chrome Beta - brave://welcome- PASSED

Person 1: 4 extensions

1.new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import
6. check Chrome Beta Person 1
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions are successfully imported and are shown in brave://extensions

step 3	step 4-5	step 6-7	step 9	step 10	step 11

Case 6: Import Extensions from Vivaldi - brave://welcome- PASSED

1. new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Vivaldi
5. click Import
6. select Vivaldi Person 1 & Vivaldi Person 2
7. click Import profiles
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar in the new-tab page
11. open brave://extensions

Confirmed extensions from both profiles are successfully imported and are shown in brave://extensions

step 3	step 4-5	step 6-7	step 9	step 10	step 11

Case 7: Import Extensions from Vivaldi - brave://settings/importData - PASSED

Prerequisite: Install Vivaldi with extensions and bookmarks

1. new profile
2. click Skip
3. click Skip on `Import Settings page
4. click Finish button on Help make Brave Better page
5. open brave:/settings/importData
6. select Vivaldi Person 1 from the drop down
7. Uncheck all and check only Extensions in the Import bookmarks and settings
8. click Import
9. click Done
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extension is successfully imported and shown in brave://extensions

step 2	step 3	step 4	step 6	step 7-8	step 10	step 11

[btlechowski]

Verification passed on

Brave	1.47.163 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	Ubuntu 18.04 LTS

Note: Currently import of extensions from Opera is not supported.

Case 1: Import Extensions via onboarding from Chrome - brave://welcome - PASSED

1. Install 1.47.x
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import button
6. check Chrome Person 1
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extension is successfully imported and shown in brave://extensions

Case 2: Import Extensions via onboarding from Chrome Canary - brave://welcome - Not supported

Chrome Canary is no supported on linux

Case 3: Import Extensions from Edge - brave://welcome - PASSED

Prerequisite: Install Edge with extensions, bookmarks, saved passwords
Profile 2: bookmarks, saved passwords & extensions
Profile 3: bookmarks, extensions

1. new profile
2. launch Brave
3. Skip Set Brave as default browser button
4. select Microsoft Edge
5. click Import
6. select Profile 1 & Profile 2
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions along with bookmarks from both profiles are successfully imported

Case 4: Import Extensions from Chrome Dev - brave://welcome- PASSED

Profile 1: 2 Extensions
Profile 2: No data (No extensions)

1.new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import
6. check Chrome Dev Person 1 and Chrome Person 2
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions are successfully imported and are shown in brave://extensions

Case 5: Import Extensions from Chrome Beta - brave://welcome- PASSED

Person 1: 4 extensions

1.new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Chrome
5. click Import
6. check Chrome Beta Person 1
7. click Import Profiles button
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extensions are successfully imported and are shown in brave://extensions

Case 6: Import Extensions from Vivaldi - brave://welcome- PASSED

1. new profile
2. launch Brave
3. click Set Brave as default browser button
4. select Vivaldi
5. click Import
6. select Vivaldi Person 1 & Vivaldi Person 2
7. click Import profiles
8. verified Setup complete page shown
9. click Finish button
10. click Extensions icon in the toolbar in the new-tab page
11. open brave://extensions

Confirmed extensions from both profiles are successfully imported and are shown in brave://extensions

Case 7: Import Extensions from Vivaldi - brave://settings/importData - PASSED

Prerequisite: Install Vivaldi with extensions and bookmarks

1. new profile
2. click Skip
3. click Skip on `Import Settings page
4. click Finish button on Help make Brave Better page
5. open brave:/settings/importData
6. select Vivaldi Person 1 from the drop down
7. Uncheck all and check only Extensions in the Import bookmarks and settings
8. click Import
9. click Done
10. click Extensions icon in the toolbar
11. open brave://extensions

Confirmed extension is successfully imported and shown in brave://extensions