Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extensions import #16442

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Fixed extensions import #16442

merged 1 commit into from
Dec 22, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Dec 21, 2022

Resolves brave/brave-browser#27487

Extensions import was broken in new import UI, fixed it.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from issue

@spylogsster spylogsster self-assigned this Dec 21, 2022
@spylogsster spylogsster force-pushed the brave-27487 branch 2 times, most recently from b9b85b9 to 10a5c0f Compare December 21, 2022 15:48
@brave brave deleted a comment from github-actions bot Dec 21, 2022
@simonhong
Copy link
Member

Could we delete this define https://github.com/brave/brave-core/blob/master/chromium_src/chrome/browser/ui/webui/settings/import_data_handler.cc#L9?
As we re-implement StartImport() at BraveImportDataHandler?

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster
Copy link
Contributor Author

Could we delete this define https://github.com/brave/brave-core/blob/master/chromium_src/chrome/browser/ui/webui/settings/import_data_handler.cc#L9? As we re-implement StartImport() at BraveImportDataHandler?

follow up brave/brave-browser#27515

@spylogsster spylogsster merged commit b1acaf0 into master Dec 22, 2022
@spylogsster spylogsster deleted the brave-27487 branch December 22, 2022 08:30
@spylogsster spylogsster restored the brave-27487 branch December 22, 2022 08:30
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 22, 2022
brave-builds added a commit that referenced this pull request Dec 22, 2022
@bsclifton bsclifton deleted the brave-27487 branch December 23, 2022 19:30
@kjozwiak
Copy link
Member

kjozwiak commented Dec 29, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.48.97 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 22H2 (Build 22621.963)

Using the STR/Cases outlined via brave/brave-browser#27487 (comment), ensured that extensions from Chromium based browsers can be imported into Brave without any issues as per the following:

  • ensured that extensions installed by users via other browsers are being imported via brave://welcome
  • ensured that extensions installed by users via other browsers are being imported via brave://settings/importData
    • ensured that extensions are being imported if it's the only option selected
    • ensured that extensions are being imported when all the options are selected
  • ensured that cookies are not being imported (for example, passwords)
  • ensured that all the extensions are being listed under brave://extensions

Importing from Chrome

Example Example Example Example Example
chromeExtensions braveChromeExtensions braveChromeExtensionsImporting braveChromeExtensions1 braveChromeExtensions2

Importing from Edge

Example Example Example Example Example
edgeExtensions braveEdgeExtensions1 braveEdgeExtensions2 braveEdgeExtensions3 braveEdgeExtensions4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions import broken
3 participants