-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed extensions import #16442
Fixed extensions import #16442
Conversation
b9b85b9
to
10a5c0f
Compare
10a5c0f
to
67900ed
Compare
Could we delete this define https://github.com/brave/brave-core/blob/master/chromium_src/chrome/browser/ui/webui/settings/import_data_handler.cc#L9? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
follow up brave/brave-browser#27515 |
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#27487 (comment), ensured that extensions from
Importing from
Importing from
|
Resolves brave/brave-browser#27487
Extensions import was broken in new import UI, fixed it.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: