-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highlight to Shields button during onboarding #27490
Labels
onboarding
Front-end related to helping a new user learn about features within the browser.
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
OS/Desktop
onboarding
Front-end related to helping a new user learn about features within the browser.
labels
Dec 21, 2022
rebron
added
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
labels
Dec 21, 2022
25 tasks
Verification
Case 1: visit to first web site with greater than 0 ads and trackers -
Confirmed Shields button in the URL bar is highlighted with pulse animation along with the bubbleConfirmed Shields onboarding is dismissedConfirmed when Brave closed and relaunched Shields onboarding is dismissedConfirmed Shields onboarding is not shown for another website in a new tab2023-12-14_13h25_15.mp4Case 2: visit to first web site with 0 ads and trackers -
Confirmed Shields onboarding is not shown on a first website with 0 ads and trackers(brave.com)Confirmed Shields onboarding is shown on a second tab with ads and trackers
Case 3: Pulse animation should not be shown with
Actual results: Pulse animation shown on the Shields onboarding 2023-12-14_13h35_27.mp4Dark theme: Encountered #34802 |
rebron
changed the title
Highlight shields button as part of onboarding
Add highlight to Shields button during onboarding
Jan 23, 2024
Verification
|
stephendonner
added
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
onboarding
Front-end related to helping a new user learn about features within the browser.
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Description
After a user goes through brave://welcome and when visiting their first web site with greater than 0 ads and trackers blocked, we will highlight the shields icon in the url bar.
Expected result:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Related issue:
#26378
#4247
The text was updated successfully, but these errors were encountered: