Pulse animation shown on Shields onboarding with hardware acceleration (--disable-gpu flag)

[MadhaviSeelam]

Description

Found while testing #27490. Shields onboarding with pulse animation is shown after completing onboarding and visited a website with ads & trackers for the first time on new profile. However, when I launched Brave with --disable-gpu flag, adding the parameter to the Brave shortcut or disabling Use hardware acceleration when available in brave://settings/system`, pulse animation is still shown

Steps to Reproduce

1. Install 1.63.41
2. launch Brave with --disable-gpu
3. visit bbc.com

Actual result:

Pulse animation is still shown

2023-12-14_13h35_27.mp4

Expected result:

No pulse animation should be shown

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.63.41 Chromium: 120.0.6099.115 (Official Build) nightly (64-bit)
-- | --
Revision | c56c5ba04606284792201770bb6cb52d1ef367b6
OS | Windows 11 Version 22H2 (Build 22621.2861)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @simonhong

[rebron]

@MadhaviSeelam I'm wondering if this is an actual user scenario.

[MadhaviSeelam]

@MadhaviSeelam I'm wondering if this is an actual user scenario.

@rebron test with --disable-gpu flag was part of the testplan unless I am understanding incorrectly.

• It's also important to test with --disable-gpu flag. In this condition you shouldn't be able to see the pulse animation.

[simonhong]

This pulse animation is shown with this condition in the code

  if (gfx::Animation::ShouldRenderRichAnimation()) {
    SchedulePulsingAnimation(layer());
  }

I didn't search about how to make return false for upstream gfx::Animation::ShouldRenderRichAnimation() method.
But current condition checking would be sufficient as its comment says it'll give false if current platform wants reduced motion.