Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't disable video background playback when enabled via BgPlaybackStudy #27550

Closed
kjozwiak opened this issue Dec 27, 2022 · 4 comments · Fixed by brave/brave-variations#497 or brave/brave-core#16514
Assignees
Labels
bug griffin OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Dec 27, 2022

Description

There's a bug with Video Background Playback were you can't disable the feature once it's been enabled by BgPlaybackStudy:Enabled. It's currently set to 100% on both Nightly & BETA and set as 25% on release as per brave/brave-variations#496. We should disable BgPlaybackStudy via Griffin on release until we fix the above bug. Users should be able to disable the feature and shouldn't be forced to use it. Originally reported by @A-t-s-u-s-h-i.

Steps to reproduce

  1. install any version of Brave on either Nightly, BETA or Release
  2. restart Brave and ensure that BgPlaybackStudy:Enabled via brave://version
  3. attempt to disable Video Background Playback via Settings

Quick Note: BgPlaybackStudy:Enabled is only enabled at 25% on the release channel as per brave/brave-variations#496.

Actual result

screen-20221227-090932.mp4

Expected result

Users should be able to disable Video Background Playback without any issues.

Issue reproduces how often

100% reproducible using the following STR/Cases.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy S10+
  • Android version: Android 13

Brave version

Brave | 1.46.146 Chromium: 108.0.5359.128 (Official Build) (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/T2B1.221118.006

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak kjozwiak added bug QA/Yes OS/Android Fixes related to Android browser functionality griffin labels Dec 27, 2022
@kjozwiak
Copy link
Member Author

CCing @SergeyZhukovsky

@kjozwiak
Copy link
Member Author

Disabling BgPlaybackStudy on production via brave/brave-variations#498 until the above is addressed.

@kjozwiak
Copy link
Member Author

kjozwiak commented Jan 7, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.154 Chromium: 108.0.5359.128 (Official Build) (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/T2B1.221118.006
  • ensured that brave://flags#brave-background-video-playback is set as Default on new profiles (disabled)
    • ensured that the Background video playback feature is disabled
  • ensured that brave://flags#brave-background-video-playback is set as Enabled once Background video playback has been enabled via Settings
  • ensured that brave://flags#brave-background-video-playback is set as Disabled rather than Default when disabling Background video playback once it was enabled

Clean Profile/First Launch

Example Example
Screenshot_20230106-195603 Screenshot_20230106-195621

Enabling Background video playback

Example Example
Screenshot_20230106-195653 Screenshot_20230106-195659

Disabling Background video playback

Example Example
Screenshot_20230106-195716 Screenshot_20230106-195723

@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 7, 2023

Verified on Samsung Galaxy Tab S7 using version:

Brave 1.46.154 Chromium: 108.0.5359.128 (Official Build) (32-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{https://github.com/brave/brave-browser/issues/1185}
OS Android 12; Build/SP2A.220305.013
  • Verified brave://flags#brave-background-video-playback is set as default on clean profile
  • Verified background video playback setting is disabled by default
  • Verified brave://flags#brave-background-video-playback is enabled when background video playback setting is enabled
  • Verified brave://flags#brave-background-video-playback is disabled when background video playback setting is disabled
  • Verified when changing video background playback setting user is prompted to relaunch browser
Defaults Defaults
screenshot-1673057444404 screenshot-1673057480805
Enabled Flags Enabled Setting Disabled (Setting Off)
screenshot-1673057536171 screenshot-1673057547181 screenshot-1673057587291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug griffin OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
4 participants