Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes turning off bg playback on Android with griffin enabled #16514

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jan 3, 2023

Resolves brave/brave-browser#27550

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 3, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 3, 2023
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.112 Chromium: 109.0.5414.61 (Official Build) canary (32-bit)
--- | ---
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Android 13; Build/T2B1.221118.006
  • ensured that brave://flags#brave-background-video-playback is set as Default on new profiles (disabled)
    • ensured that the Background video playback feature is disabled
  • ensured that brave://flags#brave-background-video-playback is set as Enabled once Background video playback has been enabled via Settings
  • ensured that brave://flags#brave-background-video-playback is set as Disabled rather than Default when disabling Background video playback once it was enabled

Clean Profile/First Launch

Example Example
Screenshot_20230104-183548 Screenshot_20230104-183653

Enabling Background video playback

Example Example
Screenshot_20230104-183627 Screenshot_20230104-183635

Disabling Background video playback

Example Example
Screenshot_20230104-183645 Screenshot_20230104-183653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't disable video background playback when enabled via BgPlaybackStudy
3 participants