Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 109.0.5414.46 to Chromium 109.0.5414.61 #27581

Closed
emerick opened this issue Dec 30, 2022 · 6 comments · Fixed by brave/brave-core#16495
Closed

Upgrade from Chromium 109.0.5414.46 to Chromium 109.0.5414.61 #27581

emerick opened this issue Dec 30, 2022 · 6 comments · Fixed by brave/brave-core#16495

Comments

@emerick
Copy link
Contributor

emerick commented Dec 30, 2022

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/109.0.5414.46..109.0.5414.61?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.47.157 or higher for 1.47.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Dec 30, 2022

Both Win x64 & Android ARM just need to run through a basic spot check as affected areas were checked via #26376 (comment), #26376 (comment) & #26376 (comment). @LaurenWags also started some upgrade cases as per #26376 (comment) but we'll need to check a C109 -> C109 upgrade now that we have two Nightly builds on C109.

Remaining work for the above:

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Windows 10 Version 21H2 (Build 19044.2364)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit) 
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	Android 12; Build/SP1A.210812.016
Example Example
screenshot-1672767182289 screenshot-1672767737715

@btlechowski
Copy link

btlechowski commented Jan 5, 2023

Verification passed on

Brave 1.47.163 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS Ubuntu 18.04 LTS

image

1. Components updates work - PASSED

  • No new components are added as part of CR 109
  • Components are updates successfully without any error
  • Existing component Url Param Classifications has been removed
    image

2. Changing settings on the following works

NTP background - PASSED

  • Confirmed enabling/disabling of Show Background Images toggle works as expected for
    - User your own
    - Brave backgrounds
    - Solid colors
    - Gradients
    - Show Sponsored Images
  • Confirmed enabling/disabling of Show Sponsored Images toggle works as expected while Show Background Images is enabled
  • Confirmed enabling/disabling of Refresh on every new tab toggle works as expected for
    - Upload from devices
    - Solid colors
    - Gradients

image
image

Shields- PASSED

  • Confirmed site specific shield settings are working as expected
  • Confirmed Global shield settings are working as expected
  • Confirmed number of blocked items are shown correctly on a opened sites when the shields is ON
  • Confirmed number of blocked items are NOT shown on shield when the shields is OFF
  • Confirmed number of blocked items aren't shown when shields Show the number... in settings is toggled OFF
  • Confirmed scripts blocking is working as expected
  • Confirmed shield settings can be changed after the upgrade

image

Permission expiration - PASSED

  • Confirmed permission expiration work as expected when selected Allow
    • until I close this site
    • for 24 hours
      -for 1 week
    • forever
  • Reset permission works as expected
  • Verified that the Block forever button correctly sets the value for Location in brave://settings/content to Block
  • Verified that the Allow button sets the value for Location in brave://settings/content to Allow
  • Verified that the site permission link at the bottom of the dialog links to brave://settings/content

image
image
image
image
image

Adding/removing items to/from playlist - PASSED

-Confirmed able to add and remove items to/from playlist

image

Settings comparison

Verified following pages:

brave://settings/clearBrowserData
image

Brave://settings/appearance -
image

brave://settings/privacy -
image

brave://settings/extensions
image

Brave startup calls

Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@LaurenWags
Copy link
Member

Superseded by #27638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment