Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 109.0.5414.61 to Chromium 109.0.5414.74 #27638

Closed
emerick opened this issue Jan 4, 2023 · 5 comments · Fixed by brave/brave-core#16529
Closed

Upgrade from Chromium 109.0.5414.61 to Chromium 109.0.5414.74 #27638

emerick opened this issue Jan 4, 2023 · 5 comments · Fixed by brave/brave-core#16529

Comments

@emerick
Copy link
Contributor

emerick commented Jan 4, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/109.0.5414.61..109.0.5414.74?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@LaurenWags
Copy link
Member

LaurenWags commented Jan 5, 2023

@brave/qa-team below summary from @kjozwiak is carried over/updated from #27581 (comment):

Both Win x64 & Android ARM just need to run through a basic spot check as affected areas were checked via #26376 (comment), #26376 (comment) & #26376 (comment).

Remaining work for the above:

@btlechowski
Copy link

btlechowski commented Jan 5, 2023

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Ubuntu 18.04 LTS

image


Verification PASSED on


Brave | 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
-- | --
Revision | e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS | Windows 10 Version 21H2 (Build 19044.2364)

image

@LaurenWags
Copy link
Member

LaurenWags commented Jan 5, 2023

Verification in progress with

Brave | 1.47.164 Chromium: 109.0.5414.74 (Official Build) (x86_64)
-- | --
Revision | e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS | macOS Version 12.6.2 (Build 21G320)

1. Components - PASSED

  • No new components are added as part of CR 109
  • Components are updates successfully without any error
  • Existing component Url Param Classifications has been removed
1.46.144 Chromium: 108.0.5359.128 1.47.164 Chromium: 109.0.5414.74
1 46 x 1 47 x

Other verifications completed under #27658 (comment).

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 5, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 5, 2023

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit) 
Revision	e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS	Android 12; Build/SP2A.220305.013
  • Check branding items
  • Check for version bump
  • Spot checked affected areas
  • Brave://components
Example Example
screenshot-1672956880321 screenshot-1672956900134

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2023

Labelled as QA/No & release-notes/exclude in favour of #27658. Added note re: what work/checks are remaining for each platform as per #27658 (comment).

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment