Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards menu item is shown in the ☰ menu for users in unavailable list countries #27629

Closed
GeetaSarvadnya opened this issue Jan 4, 2023 · 2 comments · Fixed by brave/brave-core#16557

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 4, 2023

Description

Found while testing #25275
Rewards menu item is shown in the ☰ menu for users in unavailable list countries

Steps to Reproduce

  1. Follow the steps 1 to 8 from Test Case 3 https://github.com/brave/internal/issues/981#issuecomment-1369867279
  2. Rewards menu item is shown in the ☰ menu for Cuba

Actual result:

Rewards menu item is shown in the ☰ menu for users in unavailable list countries
image

Expected result:

Rewards menu item should NOT be shown in the ☰ menu for users in unavailable list countries

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @mkarolin @Miyayes

@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2023

The above requires 1.47.168 or higher for 1.47.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jan 10, 2023

Verified with

Brave | 1.47.168 Chromium: 109.0.5414.87 (Official Build) (x86_64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.6.2 (Build 21G320)

Went through the STR/Cases outlined via #27629 (comment) and ensured that Brave Rewards was removed from the Hamburger Menu as per the following:

Region set as Cuba

8

Notice that there's no Brave Rewards being listed in hamburger menu.

@Miyayes Miyayes changed the title Rewards menu item is shown in the ☰ menu for users in OFAC list countries Rewards menu item is shown in the ☰ menu for users in unavailable list countries Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants