Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News 'back button regression' #28351

Closed
hollons opened this issue Feb 7, 2023 · 2 comments · Fixed by brave/brave-core#17182
Closed

Brave News 'back button regression' #28351

hollons opened this issue Feb 7, 2023 · 2 comments · Fixed by brave/brave-core#17182

Comments

@hollons
Copy link

hollons commented Feb 7, 2023

Description

When I select an article after scrolling down on Brave News on Desktop, after I read the article and click 'back', I'm directed to the top of the news feed instead of where I left off when clicking the original article.

Steps to Reproduce

  1. Scroll down several articles
  2. Click on an article
  3. Click on the back button

Actual result:

When clicking back I'm taken to the top of the news feed.

Expected result:

The expected result would be to be taken to where I left off in the news feed when clicking the original article.

Reproduces how often:

Reproduces every time

Brave version (brave://version info)

Version 1.47.186 Chromium: 109.0.5414.119 (Official Build) (arm64)
macOS Monterey Version 12.6.3

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@MadhaviSeelam
Copy link

Verification PASSED

Brave | 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Verified and reproduced this issue in 1.50.114

ex ex ex
image image image
  1. installed 1.51.79
  2. launched Brave
  3. opened a new-tab page
  4. scrolled a bit
  5. clicked Turn on Brave News
  6. scroll down several articles
  7. click on an article
  8. click on the browser back button

Confirmed when clicked browser back button, it has navigated to the same news card in the news feed

2023-04-07_09h48_39.mp4

@stephendonner
Copy link

stephendonner commented Apr 10, 2023

Verification PASSED using

Brave 1.51.84 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

First, reproduced using 1.50.114

example example example
Screenshot 2023-04-10 at 12 50 08 PM Screenshot 2023-04-10 at 12 50 13 PM Screenshot 2023-04-10 at 12 50 18 PM

Steps:

  1. installed 1.51.79
  2. launched Brave
  3. opened a new-tab page
  4. scrolled a bit
  5. clicked Turn on Brave News
  6. scroll down several articles
  7. click on an article
  8. click on the browser back button

Confirmed when clicking the Back button after clicking an article, the viewport scroll position isn't lost

news


Verification passed on

Brave 1.51.98 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Ubuntu 22.04 LTS

Steps:

  1. installed 1.51.98
  2. launched Brave
  3. opened a new-tab page
  4. scrolled a bit
  5. clicked Turn on Brave News
  6. scroll down several articles
  7. click on an article
  8. click on the browser back button

Confirmed when clicking the Back button after clicking an article, the viewport scroll position isn't lost

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment