Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove line for Total from wallet #1297

Closed
LaurenWags opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#580
Closed

remove line for Total from wallet #1297

LaurenWags opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#580

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 26, 2018

Test Plan

Please follow the test plan outlined under #1297 (comment).

Original Reported Issue

Description

Per discussion it was decided to remove the line item for 'Total' from the current Rewards Summary display (to be renamed per #1296).

This info is accessible from the Wallet panel/container on Brave Rewards Main Page as well as on the Brave Rewards Panel (accessible from BAT logo in URL bar).

screen shot 2018-09-26 at 3 11 25 pm

cc @davidtemkin @kjozwiak @srirambv @NejcZdovc @jenn-rhim @mandar-brave

@kjozwiak
Copy link
Member

kjozwiak commented Oct 9, 2018

@LaurenWags mind adding some test cases into the original issue and adding the QA/Test-Plan-Specified label? Thanks!

@LaurenWags
Copy link
Member Author

Test Plan:
Navigate to chrome://rewards
Enable Brave Rewards if not already enabled
Look at the Wallet panel --> Verify line for total is removed
Click on the BAT logo in URL bar. --> Verify line for total is removed

@srirambv
Copy link
Contributor

srirambv commented Oct 10, 2018

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment