Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header fixes for Google Sign-In Permission - follow up for #27723 #28440

Closed
LaurenWags opened this issue Feb 10, 2023 · 5 comments
Closed

Header fixes for Google Sign-In Permission - follow up for #27723 #28440

LaurenWags opened this issue Feb 10, 2023 · 5 comments
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@LaurenWags
Copy link
Member

Follow up issue to test #27723 in 1.50.x

Per discussion via https://bravesoftware.slack.com/archives/C6YNM6Y5S/p1676056695432439?thread_ts=1675971598.530879&cid=C6YNM6Y5S 1.50.x is where we are expecting to enable this feature. Also, additional code has been landed in 1.50.x (brave/brave-core#17088, brave/brave-core#17058, brave/brave-core#16971 as listed in above slack thread) so it doesn't make sense to test this with 1.49.x at this time.

@brave/qa-team as before, please ping @ShivanKaul or @LaurenWags for spec with further details.
@LaurenWags LaurenWags added this to the 1.50.x - Nightly milestone Feb 10, 2023
@LaurenWags LaurenWags mentioned this issue Feb 10, 2023
Closed
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 15, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 15, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1413)

and

Brave | 1.50.98 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Testcase 1: New feature flag for Google Sign-In in brave://flags - #brave-google-sign-in-permission and New permission prompt - PASSED

Case 1: Enable Google Sign-In Permission Prompt in brave://flags set to Default and no permission prompt shown for Sites that rely on 3p cookies for Google Login - PASSED

  1. Installed 1.50.92
  2. launched Brave
  3. opened a new-tab
  4. visited brave://flags
  5. confirmed a new feature flag #brave-google-sign-in-permission - Enable Google Sign-In Permission Prompt is set to default
  6. visited brave://settings/socialBlocking
  7. verified Allow use of third-party cookies for legacy Google Sign-In setting is set to enabled as a default
  8. visited brave://settings/content and clicked Additional permissions
  9. confirmed Google Sign-In entry is not shown
  10. visited brave://settings/content/googleSignIn
  11. confirmed no new page available for brave://settings/content/googleSignIn
  12. visit https://www.expensify.com
  13. click Google button
  14. confirmed no permission prompt shown but Google Sign in screen shown
step 5 step 7 step 9 step 14
image image image image

Case 2: Enable Google Sign-In Permission Prompt in brave://flags set to Enabled and permission prompt is shown for Sites that rely on 3p cookies for Google Login - PASSED

  1. continued from Case 1
    • #brave-google-sign-in-permission is set to default in brave://flags
  2. set brave://flags/#brave-google-sign-in-permission to Enabled
  3. visited brave://settings/socialBlocking
  4. confirmed Allow Google login buttons on third party sites setting is not shown
  5. visited brave://settings/content/googleSignIn
  6. new Google Sign-In page shown
  7. confirmed a new setting Sites can ask to use legacy Google Sign-In via third-party cookies is enabled by default
  8. confirmed Allowed to use third-party cookies for legacy Google Sign-In entry is shown
  9. visit https://www.expensify.com
  10. click Google button
  11. confirmed permission prompt is shown
  12. confirmed brave://settings/privacydo not haveAllow use of third-party cookies for legacy Google Sign-In` entry
step 2 step 4 step 7-8 step 11 step 12
image image image image image

Testcase 2 : New Google Sign-In content permission in brave://settings/content under Additional Permissions, also directly at brave://settings/content/googleSignIn - PASSED

Case 1: New Google Sign-In permissions shown via brave://settings/content page - PASSED

  1. new profile
  2. launch Brave
  3. open a new-tab
  4. visit brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. visit brave://settings/content
  7. click Additional permissions >>Google Sign-In
  8. confirmed Google Sign-In page is displayed
  9. confirmed Sites can ask to use legacy Google Sign-in via third-party cookies setting is enabled by default
  10. confirmed two new settings available with Add buttons under Customized behaviors section
    • Not allowed to use third-party cookies for legacy Google Sign-In
    • Allowed to use third-party cookies for legacy Google Sign-In
step 5 step 7 step 8-9
image image image

Case 2: New Google Sign-In permissions shown in brave://settings/content/googleSignIn page - PASSED

  1. continue from above Case 1:
    • Enabled Enable Google Sign-In Permission Prompt in Brave://flags
  2. visit brave://settings/content/googleSignIn in a new tab
  3. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies is enabled by default
  4. confirmed two new settings available with Add buttons under Customized behaviors section
    • Not allowed to use third-party cookies for legacy Google Sign-In
    • Allowed to use third-party cookies for legacy Google Sign-In
step 1 step 2-3
image image

Case 3: Disable default permissions Sites can ask to use legacy Google Sign-In via third-party cookies in brave://settings/content/googleSignIn - PASSED

  1. new profile
  2. launch Brave
  3. opened a new-tab
  4. visit brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. visited brave://settings/content/googleSignIn
  7. disabled Sites can ask to use legacy Google Sign-In via third-party cookies
  8. visited https://www.expensify.com/
  9. clicked Google button
  10. confirmed error message There was an error signing you in with Google error message
step 5 step 7 step 10
image image image

Testcase 3: Granting or denying permission to a website shows up at brave://settings/content/googleSignIn - PASSED

Case 1: select Allow for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launch Brave
  3. opened a new-tab
  4. visit brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. visited brave://settings/content/googleSignIn
  7. Sites can ask to use legacy Google Sign-In via third-party cookies is enabled
  8. visited https://www.expensify.com/
  9. clicked Google button
  10. confirmed permission prompt shown for the site expensify.com
  11. click Allow and keep the default permission unitl I close this site
  12. confirmed permission prompt is dismissed
  13. go to brave://settings/content/googleSignIn page
  14. confirmed https://www.expensify.com:443 site URL is shown in Allowed to use third-party cookies for legacy Google Sign-In entry
  15. click the arrow tab next to URL
  16. confirmed Allow permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.expensify.com%3A443
  17. open brave://settings/cookies in a new tab
  18. confirmed entries are shown Sites that can always use cookies are shown (for https://accounts.google.com, it reads as embedded on [.]expensify.com`. Same for https://[.]firebaseapp.com)
  19. return to https://www.expensify.com site
  20. click Google to log in to the site with Google SSO credential
  21. confirmed successfully logged in
  22. sign out and close the tab
  23. the entry https://www.expensify.com:443 is removed from Allowed to use third-party cookies for legacy Google Sign-In
  24. visit https://expensify.com again
  25. click Google button
  26. confirmed permission prompt shown for the site expensify.com
step 5 step 7 step10 step 12 step 13 step 16 step 17 step 20 step 22 step 25
image image image image image image image image image image

Case 2: select Block for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visit https://www.expensify.com in a new tab
  7. click Google button
  8. confirmed permission prompt shown for the site https://www.expensify.com.
  9. click Block
  10. confirmed permission prompt is dismissed
  11. visited brave://settings/content/googleSignIn
  12. confirmed https://www.expensify.com:443 entry is shown in Not allowed to use third-party cookies for legacy Google Sign-In entry
  13. click the arrow tab next to URL
  14. confirmed Block permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.expensify.com%3A443
  15. open brave://settings/cookies in a new tab
  16. confirmed entries are shown Sites that can never use cookies are shown (for https://accounts.google.com, it reads as embedded on [.]expensify.com`. Same for https://[.]firebaseapp.com)
  17. close the https://www.expensify.com site tab
  18. re-visit https://www.expensify.com
  19. click Google button
  20. permission prompt is shown with Allow and Block as expected
step 5 step 8 step 10 step 12 step15 step 16 step 18
image image image image image image image

Case 3: Dismiss the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visit https://www.expensify.com in a new tab
  7. click Google button
  8. confirmed permission prompt shown for the site expensify.com.
  9. click x to dismiss the modal
  10. confirmed no cookie exceptions shown in brave://settings/cookies
  11. confirmed no entry is shown in Google Sign-In page in brave://settings/content/googleSignin
  12. close the https://www.expensify.com site tab
  13. re-visit https://www.expensify.com
  14. click Google button
  15. permission prompt is shown with Allow and Block as expected
step 5 step 8 step 10 step 11 step 16
image image image image image

Testcase 4: Manually adding a site to those lists works (i.e. if joinhoney.com is added to Block then Google Sign-In doesn't work) - PASSED

Case 1: Manually add a site to Allowed to use third-party cookies for legacy Google Sign-In' - PASSED`

  1. new profile
  2. launched Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visited brave://settings/content/googleSignIn
  7. added the site https://www.expensify.com to the entry Allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed Allow in Google Sign-in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.expensify.com)
  9. open brave://settings/cookies in a new tab
  10. cookie policy per site is shown (for https://accounts.google.com/, it reads as embedded on [.]expensify.com. Same for https://[.]firebaseapp.com)
  11. visited https://www.expensify.com in a new tab
  12. click Google button
  13. No permission prompt is displayed as expected as the site is already added in step 7
  14. confirmed Google Sign-in screen displayed

Confirmed when a site is manually added in Allowed to use third-party cookies for legacy Google Sign-In entry, Google Sign-in screen displayed.

step 4-5 step 6 step 7 step 8 step 10 step 13
image image image image image image

Case 2: Remove a site that was already added to Allowed to use third-party cookies for legacy Google Sign-In' - PASSED`

  1. continued from Case 1:
    • already added https://expensify.com to is Allowed to use third-party cookies for legacy Google Sign-In' entry
    • no permission prompt shown in the https://www.expensify.com tab
  2. click 3-dot menu in the brave://settings/content/googleSignIn for the https://www.expensify.com entry
  3. click Remove
  4. confirmed https://www.expensify.com entry is removed.
  5. open brave://settings/cookies in a new tab
  6. confirmed entries in the Site that can always use cookies are removed (embedded on [.]expensify.com, and https://[.]firebaseapp.com)
  7. return to https://www.expensify.com tab
  8. click Google button
  9. confirmed permission prompt displayed
step 1a step 1b step 2-3 step 4 step 6 step 9
image image image image image image

Case 3: Manually Add a site to Not allowed to use third-party cookies for legacy Google Sign-In' - PASSED`

  1. new profile
  2. launched Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visited brave://settings/content/googleSignIn
  7. added the site https://www.expensify.com to the entry Not allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed Block in Google Sign-in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.expensify.com)
  9. open brave://settings/cookies in a new tab
  10. confirmed entries in the Site that can never use cookies are shown (embedded on [.]expensify.com, and https://[.]firebaseapp.com)
  11. visited https://www.expensify.com in a new tab
  12. click Google button
  13. confirmed There was error signing you in with Google error message displayed
step 4-5 step 7 step 8 step 10 step 14
image image image image image

Case 4: Allow a site to Not allowed to use third-party cookies for legacy Google Sign-In entry - PASSED

  1. continued from Case 3:
    • already added https://expensify.com to is Not allowed to use third-party cookies for legacy Google Sign-In' entry
      -Google Sign-in error shown in the https://www.expensify.com tab
  2. click 3-dot menu in the brave://settings/content/googleSignIn for the https://www.expensify.com entry
  3. click Allow
  4. confirmed https://www.expensify.com entry is switched and added to Allowed to use third-party cookies for legacy Google Sign-In entry
  5. open brave://settings/cookies in a new tab
  6. confirmed entries in the Site that can always use cookies are removed (embedded on [.]expensify.com, and https://[.]firebaseapp.com)
  7. return and refresh https://www.expensify.com tab
  8. click Google button
  9. confirmed No permission prompt displayed and Google Sign-in screen is shown
step 1a step 1b step 2 -3 step 4 step 7 step 9
image image image image image image

Testcase 5 : Sites that don't rely on 3p cookies for Google Login - PASSED

Case 1: - No permission prompt shown for sites that don't rely on 3p cookies - nytimes.com

  1. Install 1.50.93
  2. launch Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visit https://nytimes.com/ in a new-tab
  7. click Sign in >>Continue with Google >> successfully logged in
  8. confirmed no permission prompt shown
  9. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In is shown in
    brave://settings/content/googleSignIn
  10. confirmed site entries are not added in Sites that can always use cookies in brave://settings/cookies
step 5 step 8 step 9 step 10
image image image image

Case 2: -No permission prompt shown for sites that don't rely on 3p cookies - PASSED

Addtional testing - https://washingtonpost.com/ & https://greenhouse.io/

  1. new profile
  2. launch Brave
  3. opened a new-tab
  4. visited brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visit https://washingtonpost.com/ in a new-tab
  7. confirmed no permission prompt shown
  8. confirmed successfully logged in
  9. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In is shown in
    brave://settings/content/googleSignIn
  10. confirmed site entries are not added in brave://settings/cookies
  11. visit https://theguardian.com/ in a new-tab
  12. confirmed steps 7-10
step 5 step 7 step 9 step 10 ex step 7 step 9 step 10
image image image image image image image image

Testcase 6: Upgrade -PASSED

Case 1: Allow on permission prompt -PASSED

https://charthop.com

  1. Install 1.49.120
  2. launch Brave
  3. opened a new-tab
  4. visited brave://flags
  5. leave the default for brave-google-sign-in-permission
  6. visited https://charthop.com/
  7. click Sign In>>Sign in with Google>>no permission prompt displayed
  8. visited brave://settings/privacy
  9. verified Allow use of third-party cookies for legacy Google Sign-In entry is shown
  10. close the browser
  11. rename the profile to Brave-Beta
  12. install 1.50.98
  13. launch Brave
  14. confirmed no permission prompt shown for https://charthop.com/ when clicked on Sign in with Google
  15. Enabled Enable Google Sign-In Permission Prompt in brave://flags and click Relaunch
  16. return to https://charthop.com and click Sign-in Google
  17. confirmed permission prompt is shown
  18. clicked Allow
  19. click Sign in with Google again and successfully logged in to the site
  20. confirmed the URL https://www.app.charthop.com:443 is shown brave://settings/content/googleSignIn
  21. open brave://settings/cookies
  22. confirmed entries in the Site that can always use cookies are shown (embedded on [.]accounts.google.com, and https://[.]firebaseapp.com)
  23. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 7 step9 step 14 step 15 step 18 step 19 step 20 step 22 step 23
image image image image image image image image image image

Case 2: Block on permission prompt - PASSED

**** https://www.patreon.com/login:443****
  1. Install 1.49.120
  2. launch Brave
  3. opened a new-tab
  4. visited brave://flags
  5. leave the default for brave-google-sign-in-permission
  6. visit https://www.patreon.com/login
  7. no permission prompt displayed
  8. visited brave://settings/privacy
  9. verified Allow use of third-party cookies for legacy Google Sign-In entry is shown
  10. close the browser
  11. rename the profile to Brave-Beta
  12. install 1.50.98
  13. launch Brave
  14. confirmed no permission prompt shown forhttps://www.patreon.com/login when clicked on Google
  15. Enabled Enable Google Sign-In Permission Prompt in brave://flags and Relaunch
  16. return to https://www.patreon.com/login and click Continue with Google
  17. confirmed permission prompt is shown
  18. clicked Block
  19. confirmed permission prompt is dismissed
  20. confirmed the URL https://www.patreon.com/login:443 is shown in Not allowed to use third-party cookies for legacy Google Sign-In in brave://settings/content/googleSignIn
  21. open brave://settings/cookies
  22. confirmed entries in the Site that can never use cookies are shown (embedded on [.]accounts.google.com, and https://[.]firebaseapp.com)
  23. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 7 step 9 step 15 step 17 step 19 step 20 step 22 step 23
image image image image image image image image image
_________________________

Note: Joinhoney.com from the list may not work
https://bravesoftware.slack.com/archives/C7VLGSR55/p1679009468289999

@LaurenWags
Copy link
Member Author

Note for @brave/qa-team:

When testing this issue, be sure to use different sites than those already verified.

See https://bravesoftware.slack.com/archives/GAA4017R7/p1679086378075959?thread_ts=1673464997.445139&cid=GAA4017R7

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 21, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 21, 2023
@stephendonner
Copy link

stephendonner commented Mar 21, 2023 •
edited
Loading

Verification PASSED using

Brave 1.50.98 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Testcase 1 - New feature flag for Google Sign-In in brave://flags #brave-google-sign-in-permission and new permission prompt - PASSED

Case 1: Enable Google Sign-In Permission in brave://flags set to Default and no permission prompt shown for sites which rely on 3p cookies for Google Login - PASSED

  1. installed 1.50.98
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. confirmed a new feature flag #brave-google-sign-in-permission - Enable Google Sign-In Permission Prompt is set to default and enabled
  6. visited brave://settings/socialBlocking
  7. verified Allow use of third-party cookies for legacy Google Sign-in setting is set to Enabled as a default
  8. visited brave://settings/content and clicked Additional permissions
  9. confirmed Google Sign In entry is not shown
  10. visited brave://settings/content/googleSignIn
  11. confirmed no new page available for brave://settings/content/googleSignIn
  12. visited https://www.fandango.com
  13. clicked on the Sign In/Join link
  14. clicked the Join with Google button
  15. confirmed no permission prompt shown but Google Sign-in screen shown
step 5 step 7 step 9 step 14
Screen Shot 2023-03-21 at 3 50 53 PM Screen Shot 2023-03-21 at 3 52 55 PM Screen Shot 2023-03-21 at 3 54 14 PM Screen Shot 2023-03-21 at 4 08 46 PM

Case 2: Enable Google Sign-In Permission Prompt in brave://flags set to Enabled and permission prompt is shown for sites which rely on 3p cookies for Google Login - PASSED

  1. continued from Case 1
  • #brave-google-sign-in-permission is set to default in brave://flags
  1. set brave://flags/#brave-google-sign-in-permission to Enabled
  2. visited `brave://settings/socialBlocking
  3. confirmed Allow Google login buttons on third party sites setting is not shown
  4. visited brave://settings/content/googleSignIn
  5. new Google Sign-In page shown
  6. confirmed a new setting Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled by default
  7. confirmed Allowed to use third-party cookies for legacy Google Sign-In entry is shown
  8. visited https://www.fandango.com
  9. clicked on the Sign In/Join link
  10. clicked Sign in with Google
  11. confirmed permission prompt is shown
  12. confirmed brave://settings/privacy do not have Allow use of third-party cookies for legacy Google Sign-In entry
step 2 step 4 steps 7-8 step 12 step 13
Screen Shot 2023-03-21 at 4 21 02 PM Screen Shot 2023-03-21 at 4 21 18 PM Screen Shot 2023-03-21 at 4 23 39 PM Screen Shot 2023-03-21 at 4 24 48 PM Screen Shot 2023-03-21 at 4 25 12 PM

Testcase 2 - New Google Sign-In content permission in brave://settings/content under Additional Permissions, also directly at brave://settings/content/googleSignIn - PASSED

Case 1: New Google Sign-In permissions shown via brave://settings/content page - PASSED

  1. new profile
  2. launch Brave
  3. open a new tab
  4. open brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. visit brave://settings/content
  7. click Additional permissions --> Google Sign-In
  8. confirmed Google Sign-In page is displayed
  9. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies setting is Enabled by default
  10. confirmed two new settings available with Add buttons under Customized behaviors section
  • Not allowed to use third-party cookies for legacy Google Sign-In
  • Allowed to use third-party cookies for legacy Google Sign-In
step 5 step 7 steps 8-9
Screen Shot 2023-03-21 at 6 19 47 PM Screen Shot 2023-03-21 at 6 20 57 PM Screen Shot 2023-03-21 at 6 21 12 PM

Case 2: New Google Sign-In permissions shown in brave://settings/content/googleSignIn page - PASSED

  1. continued from above Case 1
    • Enabled Enable Google Sign-In Permission Prompt in brave://flags
  2. visit brave://settings/content/googleSignIn in a new tab
  3. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled by default
  4. confirmed two new settings available with Add buttons under Customized behaviors section
    • Not allowed to use third-party cookies for legacy Google Sign-In
    • Allowed to use third-party cookies for legacy Google Sign-In`
step 1 steps 2-3
Screen Shot 2023-03-21 at 6 27 09 PM Screen Shot 2023-03-21 at 6 27 58 PM

Case 3 - Disable default permission Sites can ask to use legacy Google Sign-In via third-party cookies in brave://settings/content/googleSignIn - PASSED

  1. new profile
  2. launch Brave
  3. open a new tab
  4. open brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. opened brave://settings/content/googleSignIn
  7. disabled Sites can ask to use legacy Google Sign-In via third-party cookies
  8. loaded https:///www.fandango.com
  9. clicked on the Sign In button
  10. clicked on the Join with Google button
  11. confirmed clicking performed no action; page remained as-is
step 5 step 7 step 11
Screen Shot 2023-03-21 at 6 40 42 PM Screen Shot 2023-03-21 at 6 41 05 PM Screen Shot 2023-03-21 at 6 41 29 PM

Testcase 3 - Granting or denying permission to a website shows up at brave://settings/content/googleSignIn - PASSED

Case 1: select Allow for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled via brave://flags and clicked Relaunch
  6. opened brave://settings/content/googleSignIn
  7. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled
  8. loaded https://www.fandango.com
  9. clicked on Sign-In
  10. clicked on Join with Google
  11. confirmed permission prompt for Fandango
  12. clicked Allow and kept the default permission until I close this site
  13. went to brave://settings/content/googleSignIn page
  14. confirmed https://www.fandango.com:443 is shown in Allowed to use third-party cookies for legacy Google Sign-In
  15. clicked the arrow icon
  16. confirmed Allow permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com%3A443
  17. opened brave://settings/cookies in a new tab
  18. confirmed entries are shown in Sites that can always use cookies https://accounts.google.com, embedded on [*.]fandango.com - same for https://[.]firebaseapp.com
  19. returned to the https://www.fandango.com site
  20. clicked Google to log in to the site with Google SSO credential
  21. (unable to log in)
  22. closed tab
  23. confirmed entry for https://www.fandango.com:443 is removed from Allowed to use third-party cookies for legacy Google Sign-In
  24. loaded https://www.fandango.com again
  25. clicked on the Sign-In button
  26. clicked on Join with Google button
  27. confirmed permission prompt dialog is shown for fandango.com
step 5 step 7 step 10 step 12 step 13 step 16 step 18 step 20 step 21 step 23 step 27
Screen Shot 2023-03-21 at 6 50 40 PM Screen Shot 2023-03-21 at 6 56 03 PM Screen Shot 2023-03-21 at 6 56 36 PM Screen Shot 2023-03-21 at 6 57 15 PM Screen Shot 2023-03-21 at 6 57 45 PM Screen Shot 2023-03-21 at 7 00 11 PM Screen Shot 2023-03-21 at 7 00 32 PM Screen Shot 2023-03-21 at 7 02 27 PM Screen Shot 2023-03-21 at 7 01 54 PM Screen Shot 2023-03-21 at 7 04 51 PM Screen Shot 2023-03-21 at 7 05 14 PM

Case 2: select Block for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://www.fandango.com in a new tab
  7. clicked the Sign-In link
  8. clicked the Join with Google button
  9. confirmed permission prompt is shown for the site http://www.fandango.com
  10. clicked on Block
  11. confirmed permission prompt is dismissed
  12. opened brave://settings/content/googleSignIn
  13. confirmed https://www.fandango.com:443 entry is shown in Not allowed to use third-party cookies for legacy Google Sign-In
  14. clicked the arrow next to the URL
  15. confirmed Block permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com%3A443
  16. opened brave://settings/cookies in a new tab
  17. confirmed entries are shown in Sites that can never use cookies are shown
  18. closed the http://www.fandango.com tab
  19. loaded https://www.fandango.com in a new tab
  20. clicked on the Sign-In link
  21. clicked on the Join with Google button
  22. confirmed the permission prompt is shown, with Allow and Block options
step 5 step 9 step 11 step 13 step 16 step 17 step 22
Screen Shot 2023-03-21 at 9 31 07 PM Screen Shot 2023-03-21 at 9 32 11 PM Screen Shot 2023-03-21 at 9 32 19 PM Screen Shot 2023-03-21 at 9 32 39 PM Screen Shot 2023-03-21 at 9 32 57 PM Screen Shot 2023-03-21 at 9 34 26 PM Screen Shot 2023-03-21 at 9 36 44 PM

Case 3 - Dismiss the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://www.fandango.com in a new tab
  7. clicked on the Sign-In link
  8. clicked on the Join with Google link
  9. confirmed permission prompt shown for the site https://www.fandango.com
  10. clicked x to dismiss the modal
  11. confirmed no cookie exceptions shown in brave://settings/cookies
  12. confirmed no entry is shown in Google Sign-In page in brave://settings/content/googleSignIn
  13. closed the https://www.fandango.com tab
  14. loaded http://www.fandango.com in a new tab
  15. clicked on the Sign-In link
  16. clicked on the Join with Google button
  17. confirmed permission prompt is shown with Allow and Block. as expected
step 5 step 9 step 11 step 12 step 17
Screen Shot 2023-03-21 at 10 05 49 PM Screen Shot 2023-03-21 at 10 07 20 PM Screen Shot 2023-03-21 at 10 09 05 PM Screen Shot 2023-03-21 at 10 09 51 PM Screen Shot 2023-03-21 at 10 10 40 PM

Testcase 4 - Manually adding a site to the above list works - PASSED

Case 1: Manually adding a site to Allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visited brave://settings/content/googleSignIn
  7. added the site https://www.fandango.com to the entry Allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed https://www.fandango.com appeared in Allowed to use third-party cookies for legacy Google Sign-In on brave://settings/content/googleSignIn
  9. clicked on the arrow and confirmed Allow in Google Sign-in on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com)
  10. opened brave://settings/cookies in a new tab
  11. cookie policy per site is shown (for https://accounts.google.com/, it reads as embedded on [.]fandango.com. Same for https://[.]firebaseapp.com)
  12. visited https://www.fandango.com in a new tab
  13. clicked the Sign-In/Join link
  14. clicked on the Join with Google button
  15. No permission prompt is displayed as expected as the site is already added in step 7
  16. confirmed Google Sign-in screen displayed
step 5 step 7 step 8 step 9 step 11 step 16
Screen Shot 2023-03-21 at 10 49 47 PM Screen Shot 2023-03-21 at 10 53 26 PM Screen Shot 2023-03-21 at 10 59 09 PM Screen Shot 2023-03-21 at 10 59 13 PM Screen Shot 2023-03-21 at 10 59 59 PM Screen Shot 2023-03-21 at 11 06 30 PM

Case 2: Remove a site that was already added to Allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. continued from Case 1:
    • already added https://www.fandango.com to `Allowed to use third-party cookies for legacy Google Sign-In' entry
    • no permission prompt shown in the https://www.fandango.com tab
  2. clicked 3-dot menu in the brave://settings/content/googleSignIn for the https://www.fandango.com entry
  3. clicked Remove
  4. confirmed https://www.fandango.com entry is removed.
  5. opened brave://settings/cookies in a new tab
  6. confirmed entries in the Site that can always use cookies are removed (embedded on [.]expensify.com, and https://[.]firebaseapp.com)
  7. return to https://www.fandango.com/ tab
  8. click the Sign-In/Join link
  9. click the Join with Google button
  10. confirmed permission prompt displayed
step 1a step 1b steps 2-3 step 4 step 6 step 10
Screen Shot 2023-03-21 at 11 27 07 PM Screen Shot 2023-03-21 at 11 27 50 PM Screen Shot 2023-03-21 at 11 28 42 PM Screen Shot 2023-03-21 at 11 29 06 PM Screen Shot 2023-03-21 at 11 30 46 PM Screen Shot 2023-03-21 at 11 31 37 PM

Case 3: Manually Add a site to Not allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. opened brave://settings/content/googleSignIn
  7. added the site https://www.fandango.com to the entry Not allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed Block in Google Sign-in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com
  9. opened brave://settings/cookies in a new tab
  10. confirmed entries in the Sites that can never use cookies are shown (embedded on [.]fandango.com, and https://[.]firebaseapp.com)
  11. loaded https://www.fandango.com in a new tab
  12. clicked on the Sign-In/Join link
  13. clicked on the Join with Google button
  14. confirmed nothing happens when clicking on the Join with Google button
steps 5 step 7 step 8 step 10 step 14
Screen Shot 2023-03-21 at 11 42 39 PM Screen Shot 2023-03-21 at 11 46 40 PM Screen Shot 2023-03-21 at 11 43 48 PM Screen Shot 2023-03-21 at 11 48 11 PM Screen Shot 2023-03-21 at 11 44 36 PM

Case 4: Allow a site to Not allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. continued from Case 3:
    • already added https://www.fandango.com to `Not allowed to use third-party cookies for legacy Google Sign-In' entry\
    • no errors or permission prompts shown in the https://www.fandango.com tab
  2. clicked the 3-dots menu in brave://settings/content/googleSignIn for the https://www.fandango.com entry
  3. clicked Allow
  4. confirmed https://www.fandango.com entry is switched and added to Allowed to use third-party cookies for legacy Google Sign-In entry
  5. opened brave://settings/cookies in a new tab
  6. confirmed entries in the Sites that can always use cookies are present (embedded on [.]fandango.com, and https://[.]firebaseapp.com)
  7. returned and refreshed the https://www.fandango.com tab
  8. clicked on the Sign-In/Join link
  9. clicked on the Join with Google button
  10. confirmed no permission prompt displayed and Google Sign-in screen is shown
step 1a step 1b steps 2-3 step 4 step 6 step 10
Screen Shot 2023-03-21 at 11 55 33 PM Screen Shot 2023-03-21 at 11 56 21 PM Screen Shot 2023-03-21 at 11 58 28 PM Screen Shot 2023-03-21 at 11 58 31 PM Screen Shot 2023-03-22 at 12 00 39 AM Screen Shot 2023-03-22 at 12 08 01 AM

Testcase 5 - Sites which don't rely on 3p cookies for Google Login - PASSED

Case 1: No permission prompt shown for sites which don't rely on 3p cookies - PASSED

  1. installed 1.50.98
  2. launch Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled and clicked Relaunch
  6. visited https://greenhouse.io in a new-tab
  7. clicked Sign in and then Sign in with Google
  8. confirmed no permission prompt shown
  9. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In is shown in brave://settings/content/googleSignIn
  10. confirmed site entries are not added in Sites that can always use cookies in brave://settings/cookies
step 5 step 7a step 7b step 7c step 9 step 10
Screen Shot 2023-03-22 at 12 26 08 AM Screen Shot 2023-03-22 at 12 26 38 AM Screen Shot 2023-03-22 at 12 26 59 AM Screen Shot 2023-03-22 at 12 27 25 AM Screen Shot 2023-03-22 at 12 28 02 AM Screen Shot 2023-03-22 at 12 28 23 AM

Case 2: No permission prompt shown for sites which don't rely on 3p cookies - PASSED

  1. new profile
  2. launch Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://haynet.horse in a new-tab
  7. confirmed no permission prompt shown
  8. confirmed successfully logged in
  9. confirmed site entries are not added in brave://settings/cookies
  10. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In on brave://settings/content/googleSignIn
  11. loaded https://www.crio.do in a new-tab
  12. confirmed steps 7-10
step 5 step 7a (haynet.horse) step 7b step 8 step 9 step 10 step 7 (crio.do) step 8 step 9 step 10
Screen Shot 2023-03-22 at 12 41 39 AM Screen Shot 2023-03-22 at 12 42 20 AM Screen Shot 2023-03-22 at 12 42 32 AM Screen Shot 2023-03-22 at 12 43 30 AM Screen Shot 2023-03-22 at 12 43 45 AM Screen Shot 2023-03-22 at 12 44 00 AM Screen Shot 2023-03-22 at 12 45 09 AM Screen Shot 2023-03-22 at 12 45 28 AM Screen Shot 2023-03-22 at 12 45 36 AM Screen Shot 2023-03-22 at 12 45 43 AM

Testcase 6 - Upgrade - PASSED

Case 1: Allow on permission prompt - PASSED

  1. installed 1.49.128
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. left default for #brave-google-sign-in-permission
  6. loaded https://www.500px.com
  7. clicked Log in
  8. clicked Log in with Google
  9. opened brave://settings/socialBlocking
  10. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is shown
  11. closed Brave
  12. renamed the profile to Brave-Browser-Beta
  13. confirmed no permission prompt shown for https://www.500px.com when clicking on Sign in with Google
  14. enabled Enable Google Sign-In Permission Prompt in brave://flags and clicked Relaunch
  15. returned to https://www.500px.com and clicked Sign in with Google
  16. confirmed permission prompt is shown
  17. clicked Allow
  18. clicked Sign in with Google again and logged in
  19. confirmed the URL https://www.500px.com:443 is shown brave://settings/content/googleSignIn
  20. opened brave://settings/cookies
  21. confirmed entries in the Sites that can always use cookies
  22. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 8 step 10 step 13 step 14 steps 16-17 step 18 step 19 step 21 step 22
Screen Shot 2023-03-22 at 4 18 32 PM Screen Shot 2023-03-22 at 4 15 11 PM Screen Shot 2023-03-22 at 4 25 49 PM Screen Shot 2023-03-22 at 4 45 58 PM Screen Shot 2023-03-22 at 4 46 37 PM Screen Shot 2023-03-22 at 4 47 14 PM Screen Shot 2023-03-22 at 4 48 08 PM Screen Shot 2023-03-22 at 4 48 29 PM Screen Shot 2023-03-22 at 4 48 57 PM Screen Shot 2023-03-22 at 4 49 33 PM

Case 2: Block on permission prompt - PASSED

  1. installed 1.49.128
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. left the default for brave-google-sign-in-permission
  6. loaded https://www.appfigures.com and clicked on Log in, then Log in with Google
  7. confirmed no permission prompt displayed
  8. opened brave://settings/socialBlocking
  9. verified Allow use of third-party cookies for legacy Google Sign-In entry is shown
  10. closed Brave
  11. renamed the profile to Brave-Browser-Beta
  12. installed 1.50.99
  13. launched Brave
  14. confirmed no permission prompt shown for https://www.appfigures.com when clicked on Log in with Google
  15. enabled Enable Google Sign-In Permission Prompt in brave://flags and clicked Relaunch
  16. returned to https://www.appfigures.com and clicked on Log in with Google
  17. confirmed permission prompt is shown
  18. clicked Block
  19. confirmed permission prompt is dismissed
  20. confirmed the URL https://www.appfigures.com/login:443 is shown in Not allowed to use third-party cookies for legacy Google Sign-In in brave://settings/content/googleSignIn
  21. open brave://settings/cookies
  22. confirmed entries in the Site that can never use cookies are shown (embedded on [.]accounts.google.com, and https://[.]firebaseapp.com)
  23. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 7 step 8 step 15 step 17 step 20 step 22 step 23
Screen Shot 2023-03-22 at 5 27 39 PM Screen Shot 2023-03-22 at 5 37 21 PM Screen Shot 2023-03-22 at 5 37 38 PM Screen Shot 2023-03-22 at 5 40 42 PM Screen Shot 2023-03-22 at 5 41 06 PM Screen Shot 2023-03-22 at 5 41 34 PM Screen Shot 2023-03-22 at 5 42 19 PM Screen Shot 2023-03-22 at 5 42 41 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 23, 2023
@MadhaviSeelam MadhaviSeelam mentioned this issue Mar 27, 2023
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 30, 2023 •
edited
Loading

Verification PASSED on

Brave	1.50.107 Chromium: 112.0.5615.39 (Official Build) beta (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Linux

Testcase 1 - New feature flag for Google Sign-In in brave://flags #brave-google-sign-in-permission and new permission prompt - PASSED

Case 1: Enable Google Sign-In Permission in brave://flags set to Default and no permission prompt shown for sites which rely on 3p cookies for Google Login - PASSED

  1. installed 1.50.107
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. confirmed a new feature flag #brave-google-sign-in-permission - Enable Google Sign-In Permission Prompt is set to default and enabled
  6. visited brave://settings/socialBlocking
  7. verified Allow use of third-party cookies for legacy Google Sign-in setting is set to Enabled as a default
  8. visited brave://settings/content and clicked Additional permissions
  9. confirmed Google Sign In entry is not shown
  10. visited brave://settings/content/googleSignIn
  11. confirmed no new page available for brave://settings/content/googleSignIn
  12. visited https://www.fandango.com
  13. clicked on the Sign In/Join link
  14. clicked the Join with Google button
  15. confirmed no permission prompt shown but Google Sign-in screen shown
step 5 step 7 step 9 step 14
image image image image

Case 2: Enable Google Sign-In Permission Prompt in brave://flags set to Enabled and permission prompt is shown for sites which rely on 3p cookies for Google Login - PASSED

  1. continued from Case 1
  • #brave-google-sign-in-permission is set to default in brave://flags
  1. set brave://flags/#brave-google-sign-in-permission to Enabled
  2. visited `brave://settings/socialBlocking
  3. confirmed Allow Google login buttons on third party sites setting is not shown
  4. visited brave://settings/content/googleSignIn
  5. new Google Sign-In page shown
  6. confirmed a new setting Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled by default
  7. confirmed Allowed to use third-party cookies for legacy Google Sign-In entry is shown
  8. visited https://www.expensify.com/
  9. clicked on the Sign In/Join link
  10. clicked Sign in with Google
  11. confirmed permission prompt is shown
  12. confirmed brave://settings/privacy do not have Allow use of third-party cookies for legacy Google Sign-In entry
step 2 step 4 steps 7-8 step 12 step 13
image image image image image

Testcase 2 - New Google Sign-In content permission in brave://settings/content under Additional Permissions, also directly at brave://settings/content/googleSignIn - PASSED

Case 1: New Google Sign-In permissions shown via brave://settings/content page - PASSED

  1. new profile
  2. launch Brave
  3. open a new tab
  4. open brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. visit brave://settings/content
  7. click Additional permissions --> Google Sign-In
  8. confirmed Google Sign-In page is displayed
  9. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies setting is Enabled by default
  10. confirmed two new settings available with Add buttons under Customized behaviors section
  • Not allowed to use third-party cookies for legacy Google Sign-In
  • Allowed to use third-party cookies for legacy Google Sign-In
step 5 step 7 steps 8-9
image image image

Case 2: New Google Sign-In permissions shown in brave://settings/content/googleSignIn page - PASSED

  1. continued from above Case 1
    • Enabled Enable Google Sign-In Permission Prompt in brave://flags
  2. visit brave://settings/content/googleSignIn in a new tab
  3. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled by default
  4. confirmed two new settings available with Add buttons under Customized behaviors section
    • Not allowed to use third-party cookies for legacy Google Sign-In
    • Allowed to use third-party cookies for legacy Google Sign-In`
step 1 steps 2-3
image image

Case 3 - Disable default permission Sites can ask to use legacy Google Sign-In via third-party cookies in brave://settings/content/googleSignIn - PASSED

  1. new profile
  2. launch Brave
  3. open a new tab
  4. open brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled in brave://flags and click Relaunch
  6. opened brave://settings/content/googleSignIn
  7. disabled Sites can ask to use legacy Google Sign-In via third-party cookies
  8. loaded developers.google.com or google.com
  9. clicked on the Sign In button
  10. clicked on the Join with Google button
  11. confirmed clicking performed no action; page remained as-is
step 5 step 7 step 11
image image image

Testcase 3 - Granting or denying permission to a website shows up at brave://settings/content/googleSignIn - PASSED

Case 1: select Allow for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set Enable Google Sign-In Permission Prompt to Enabled via brave://flags and clicked Relaunch
  6. opened brave://settings/content/googleSignIn
  7. confirmed Sites can ask to use legacy Google Sign-In via third-party cookies is Enabled
  8. loaded https://www.expensify.com/
  9. clicked on Sign-In
  10. clicked on Join with Google
  11. confirmed permission prompt for Fandango
  12. clicked Allow and kept the default permission until I close this site
  13. went to brave://settings/content/googleSignIn page
  14. confirmed https://www.fandango.com:443 is shown in Allowed to use third-party cookies for legacy Google Sign-In
  15. clicked the arrow icon
  16. confirmed Allow permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com%3A443
  17. opened brave://settings/cookies in a new tab
  18. confirmed entries are shown in Sites that can always use cookies https://accounts.google.com, embedded on [*.]fandango.com - same for https://[.]firebaseapp.com
  19. returned to the https://www.expensify.com/ site
  20. clicked Google to log in to the site with Google SSO credential
  21. (unable to log in)
  22. closed tab
  23. confirmed entry for https://www.fandango.com:443 is removed from Allowed to use third-party cookies for legacy Google Sign-In
  24. loaded https://www.expensify.com/ again
  25. clicked on the Sign-In button
  26. clicked on Join with Google button
  27. confirmed permission prompt dialog is shown for https://www.expensify.com
step 5 step 7 step 10 step 12 step 13 step 16 step 18 step 20 step 21 step 23 step 27
image image image image image image image image image image image

Case 2: select Block for default permission until I close this site in the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://www.expensify.com/ in a new tab
  7. clicked the Sign-In link
  8. clicked the Join with Google button
  9. confirmed permission prompt is shown for the site http://www.fandango.com
  10. clicked on Block
  11. confirmed permission prompt is dismissed
  12. opened brave://settings/content/googleSignIn
  13. confirmed https://www.fandango.com:443 entry is shown in Not allowed to use third-party cookies for legacy Google Sign-In
  14. clicked the arrow next to the URL
  15. confirmed Block permission is shown for Google Sign-In in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com%3A443
  16. opened brave://settings/cookies in a new tab
  17. confirmed entries are shown in Sites that can never use cookies are shown
  18. closed the https://www.expensify.com/ tab
  19. loaded https://www.expensify.com/ in a new tab
  20. clicked on the Sign-In link
  21. clicked on the Join with Google button
  22. confirmed the permission prompt is shown, with Allow and Block options
step 5 step 9 step 11 step 13 step 15 step 16 step 17 step 22
image image image image image image image

Case 3 - Dismiss the permission prompt - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://www.fandango.com in a new tab
  7. clicked on the Sign-In link
  8. clicked on the Join with Google link
  9. confirmed permission prompt shown for the site https://www.fandango.com
  10. clicked x to dismiss the modal
  11. confirmed no cookie exceptions shown in brave://settings/cookies
  12. confirmed no entry is shown in Google Sign-In page in brave://settings/content/googleSignIn
  13. closed the https://www.fandango.com tab
  14. loaded http://www.fandango.com in a new tab
  15. clicked on the Sign-In link
  16. clicked on the Join with Google button
  17. confirmed permission prompt is shown with Allow and Block. as expected
step 5 step 9 step 11 step 12 step 17
image image image image image

Testcase 4 - Manually adding a site to the above list works - PASSED

Case 1: Manually adding a site to Allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. visited brave://settings/content/googleSignIn
  7. added the site https://www.expensify.com to the entry Allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed https://www.expensify.com appeared in Allowed to use third-party cookies for legacy Google Sign-In on brave://settings/content/googleSignIn
  9. clicked on the arrow and confirmed Allow in Google Sign-in on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com)
  10. opened brave://settings/cookies in a new tab
  11. cookie policy per site is shown (for https://accounts.google.com/, it reads as embedded on [.]fandango.com. Same for https://[.]firebaseapp.com)
  12. visited https://www.expensify.com in a new tab
  13. clicked the Sign-In/Join link
  14. clicked on the Join with Google button
  15. No permission prompt is displayed as expected as the site is already added in step 7
  16. confirmed Google Sign-in screen displayed
step 5 step 7 step 8 step 9 step 11 step 16
image image image image image image

Case 2: Remove a site that was already added to Allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. continued from Case 1:
    • already added https://www.fandango.com to `Allowed to use third-party cookies for legacy Google Sign-In' entry
    • no permission prompt shown in the https://www.fandango.com tab
  2. clicked 3-dot menu in the brave://settings/content/googleSignIn for the https://www.fandango.com entry
  3. clicked Remove
  4. confirmed https://www.fandango.com entry is removed.
  5. opened brave://settings/cookies in a new tab
  6. confirmed entries in the Site that can always use cookies are removed (embedded on [.]expensify.com, and https://[.]firebaseapp.com)
  7. return to https://www.expensify.com/ tab
  8. click the Sign-In/Join link
  9. click the Join with Google button
  10. confirmed permission prompt displayed
step 1a step 1b steps 2-3 step 4 step 6 step 10
image image image image image image

Case 3: Manually Add a site to Not allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. new profile
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. opened brave://settings/content/googleSignIn
  7. added the site https://www.expensify.com to the entry Not allowed to use third-party cookies for legacy Google Sign-In (make sure to enter www for the site name)
  8. confirmed Block in Google Sign-in brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.fandango.com
  9. opened brave://settings/cookies in a new tab
  10. confirmed entries in the Sites that can never use cookies are shown (embedded on [.]fandango.com, and https://[.]firebaseapp.com)
  11. loaded https://www.expensify.com in a new tab
  12. clicked on the Sign-In/Join link
  13. clicked on the Join with Google button
  14. confirmed nothing happens when clicking on the Join with Google button
steps 5 step 7 step 8 step 10 step 14
image image image image image

Case 4: Allow a site to Not allowed to use third-party cookies for legacy Google Sign-In - PASSED

  1. continued from Case 3:
    • already added https://www.fandango.com to `Not allowed to use third-party cookies for legacy Google Sign-In' entry\
    • no errors or permission prompts shown in the https://www.fandango.com tab
  2. clicked the 3-dots menu in brave://settings/content/googleSignIn for the https://www.expensify.com entry
  3. clicked Allow
  4. confirmed https://www.fandango.com entry is switched and added to Allowed to use third-party cookies for legacy Google Sign-In entry
  5. opened brave://settings/cookies in a new tab
  6. confirmed entries in the Sites that can always use cookies are present (embedded on [.]fandango.com, and https://[.]firebaseapp.com)
  7. returned and refreshed the https://www.expensify.com tab
  8. clicked on the Sign-In/Join link
  9. clicked on the Join with Google button
  10. confirmed no permission prompt displayed and Google Sign-in screen is shown
step 1a step 1b steps 2-3 step 4 step 6 step 10
image image image image image image

Testcase 5 - Sites which don't rely on 3p cookies for Google Login - PASSED

Case 1: No permission prompt shown for sites which don't rely on 3p cookies - PASSED

  1. installed 1.50.98
  2. launch Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled and clicked Relaunch
  6. visited https://greenhouse.io in a new-tab
  7. clicked Sign in and then Sign in with Google
  8. confirmed no permission prompt shown
  9. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In is shown in brave://settings/content/googleSignIn
  10. confirmed site entries are not added in Sites that can always use cookies in brave://settings/cookies
step 5 step 7a step 7b step 7c step 9 step 10
image image image image image

Case 2: No permission prompt shown for sites which don't rely on 3p cookies - PASSED

  1. new profile
  2. launch Brave
  3. opened a new tab
  4. opened brave://flags
  5. set #brave-google-sign-in-permission to Enabled
  6. loaded https://haynet.horse in a new-tab
  7. confirmed no permission prompt shown
  8. confirmed successfully logged in
  9. confirmed site entries are not added in brave://settings/cookies
  10. confirmed site is not added under Allowed to use third-party cookies for legacy Google Sign-In on brave://settings/content/googleSignIn
  11. loaded https://www.crio.do in a new-tab
  12. confirmed steps 7-10
step 5 step 7a (haynet.horse) step 7b step 8 step 9 step 10 step 7 (crio.do) step 8 step 9 step 10
image image image image image image image image image image

Testcase 6 - Upgrade - PASSED

Case 1: Allow on permission prompt - PASSED

  1. installed 1.49.128
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. left default for #brave-google-sign-in-permission
  6. loaded https://www.500px.com
  7. clicked Log in
  8. clicked Log in with Google
  9. opened brave://settings/socialBlocking
  10. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is shown
  11. closed Brave
  12. renamed the profile to Brave-Browser-Beta
  13. confirmed no permission prompt shown for https://www.500px.com when clicking on Sign in with Google
  14. enabled Enable Google Sign-In Permission Prompt in brave://flags and clicked Relaunch
  15. returned to https://www.500px.com and clicked Sign in with Google
  16. confirmed permission prompt is shown
  17. clicked Allow
  18. clicked Sign in with Google again and logged in
  19. confirmed the URL https://www.500px.com:443 is shown brave://settings/content/googleSignIn
  20. opened brave://settings/cookies
  21. confirmed entries in the Sites that can always use cookies
  22. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 8 step 10 step 13 step 14 steps 16-17 step 18 step 19 step 21 step 22
image image image image image image image image image image

Case 2: Block on permission prompt - PASSED

  1. installed 1.49.128
  2. launched Brave
  3. opened a new tab
  4. opened brave://flags
  5. left the default for brave-google-sign-in-permission
  6. loaded https://www.appfigures.com and clicked on Log in, then Log in with Google
  7. confirmed no permission prompt displayed
  8. opened brave://settings/socialBlocking
  9. verified Allow use of third-party cookies for legacy Google Sign-In entry is shown
  10. closed Brave
  11. renamed the profile to Brave-Browser-Beta
  12. installed 1.50.99
  13. launched Brave
  14. confirmed no permission prompt shown for https://www.appfigures.com when clicked on Log in with Google
  15. enabled Enable Google Sign-In Permission Prompt in brave://flags and clicked Relaunch
  16. returned to https://www.appfigures.com and clicked on Log in with Google
  17. confirmed permission prompt is shown
  18. clicked Block
  19. confirmed permission prompt is dismissed
  20. confirmed the URL https://www.appfigures.com/login:443 is shown in Not allowed to use third-party cookies for legacy Google Sign-In in brave://settings/content/googleSignIn
  21. open brave://settings/cookies
  22. confirmed entries in the Site that can never use cookies are shown (embedded on [.]accounts.google.com, and https://[.]firebaseapp.com)
  23. confirmed Allow use of third-party cookies for legacy Google Sign-In entry is not shown in brave://settings/privacy
step 5 step 7 step 8 step 15 step 17 step 20 step 22 step 23
image image image image image image image image

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@LaurenWags
Copy link
Member Author

changing to release-notes/exclude per https://brave.com/privacy-updates/24-google-sign-in-permission/

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
Development

No branches or pull requests
4 participants
@stephendonner @LaurenWags @GeetaSarvadnya @MadhaviSeelam