Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements: Reload page after permission grant for popups + use heuristics to figure if auth flow uses 3p cookies #17058

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Feb 6, 2023

Resolves brave/brave-browser#28323

Also add Firebase-specific tests.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Allowing the Google Sign-In permission prompt on any website in https://docs.google.com/spreadsheets/d/1323Jfy5l1Iotcvv2hdzW-HTSz7A0698wM9XFbdICVjw/edit#gid=0 should reload the page.
  2. Using Google Sign-In on any other website apart from that list should not bring up Google Sign-In permission prompt and should just work e.g. nytimes.com, washingtonpost.com

@ShivanKaul ShivanKaul changed the title Reload page after permission grant for popups Reload page after permission grant for popups + use heuristics to figure if auth flow uses 3p cookies Feb 7, 2023
@ShivanKaul ShivanKaul changed the title Reload page after permission grant for popups + use heuristics to figure if auth flow uses 3p cookies UX improvements: Reload page after permission grant for popups + use heuristics to figure if auth flow uses 3p cookies Feb 7, 2023
@ShivanKaul ShivanKaul force-pushed the enhancement/google-sign-in/reload-tab-for-popups branch from 92f241f to 28286a5 Compare February 7, 2023 01:00
@ShivanKaul ShivanKaul force-pushed the enhancement/google-sign-in/reload-tab-for-popups branch from 28286a5 to 3314b8e Compare February 7, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sign-In UX improvements: reload tab, only request permission for 3p cookie flows
2 participants