Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add the ability to allow/block individual scripts in Shields (webui part) #28510

Closed
spylogsster opened this issue Feb 14, 2023 · 3 comments · Fixed by brave/brave-core#17221
Closed

Re-add the ability to allow/block individual scripts in Shields (webui part) #28510

spylogsster opened this issue Feb 14, 2023 · 3 comments · Fixed by brave/brave-core#17221
Assignees
@spylogsster
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Feb 14, 2023 •
edited
Loading

WebUI part for #24593 to apply design:
image
@spylogsster spylogsster added feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Desktop labels Feb 14, 2023
@spylogsster spylogsster self-assigned this Feb 14, 2023
This was referenced Feb 15, 2023
Merged
Merged
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 7, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Case 1: Per-site - Block/Allow Block scripts setting via Shield panel

  1. Install 1.51.79
  2. launch Brave
  3. visited https://www.cnn.com/ in a new tab
  4. clicked on Shields icon to open Shields panel
  5. toggled On Block scripts setting
  6. clicked on the blocked script count link (10)
  7. clicked Allow all
  8. confirmed Allowed scripts (10) and Blocked scripts (42) shown
  9. clicked Shields arrow to return the Shields panel
  10. confirmed blocked scripts count shown (42)
  11. clicked again on the block script count
  12. clicked Block all to return show blocked scripts
  13. clicked allow/block on individual scripts
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel show correct blocked count next to Block scripts setting
step 5 step 7 step 8 step 10 step 11 step 12 step 13 Shields panel
image image image image image image image image

Case 2: Global settings - Block/Allow Block scripts setting via brave://settings/shields

  1. new profile
  2. launched Brave
  3. opened brave://settings/shields
  4. toggled On Block scripts setting
  5. visited https://www.nytimes.com/ in a new tab
  6. clicked on Shields icon to open Shields panel
  7. confirmed Block scripts is enabled and count (8) shown
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel show correct blocked count next to Block scripts setting
2023-04-06_17h26_17.mp4

Case 3: Upgrade - new Block scripts UI in the Shields panel

1.Install 1.50.114
2. launch Brave
3. visited https://www.cnn.com/ in a new tab
4. clicked on Shields icon to open Shields panel
5. toggled On Block scripts setting
6. clicked on the blocked script count link (10)
7. verified 10 blocked scripts shown
8. closed the browser and renamed the profile to Brave-Browser-Beta
9. installed 1.51. 79
10. confirmed new UI (Allow all) is shown
11. clicked Allow all
12. confirmed Allow all and Block all scripts shown
13. clicked Shields arrow to return the Shields panel
14. confirmed blocked scripts count shown (42)
15. clicked again on the block script count
16. clicked Block all to return show blocked scripts
17. clicked allow/block on individual scripts

  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel show correct blocked count next to Block scripts setting
step 7 step 10-11 step 12 step 14 step 17
image image image image image

@stephendonner stephendonner added QA/Test-Plan-Specified QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 7, 2023
@stephendonner
Copy link

stephendonner commented Apr 7, 2023 •
edited by btlechowski
Loading

Verification PASSED using

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Case 1: Per-site - Block/Allow Block scripts setting via Shields panel - PASSED

Steps:

  1. installed 1.51.80
  2. launched Brave
  3. loaded https://www.nbcnews.com/now in a new tab
  4. clicked on Shields icon to open Shields panel
  5. toggled Block scripts setting to On
  6. clicked on the blocked script count link (38)
  7. clicked Allow all
  8. confirmed Allowed scripts (37) and Blocked scripts (3) shown
  9. clicked <--- Shields to return the Shields panel
  10. confirmed blocked scripts count shown (37)
  11. clicked again on the block script count
  12. clicked Block all to return show blocked scripts
  13. clicked allow/block on individual scripts
  • Confirmed able to toggle scripts via Allow all and Block all
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel shows correct blocked count next to Block scripts setting
step 5 step 7 step 8 step 10 step 11 step 12 step 13 Shields panel
Screenshot 2023-04-07 at 5 03 11 PM Screenshot 2023-04-07 at 5 03 16 PM Screenshot 2023-04-07 at 5 03 49 PM Screenshot 2023-04-07 at 5 04 40 PM Screenshot 2023-04-07 at 5 03 49 PM Screenshot 2023-04-07 at 5 20 27 PM Screenshot 2023-04-07 at 5 15 14 PM Screenshot 2023-04-07 at 5 17 23 PM

Case 2: Global settings - Block/Allow Block scripts setting via brave://settings/shields - PASSED

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/shields
  4. toggled Block scripts setting to On
  5. opened https://www.rt.com in a new tab
  6. clicked on Shields icon to open Shields panel
  7. confirmed Block scripts is enabled and count (9) shown
  8. clicked through to see the breakdown
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel shows correct blocked count next to Block scripts setting
step 3 step 4 step 5 steps 6-7 step 8
Screenshot 2023-04-07 at 5 34 13 PM Screenshot 2023-04-07 at 5 37 21 PM Screenshot 2023-04-07 at 5 38 00 PM Screenshot 2023-04-07 at 5 38 38 PM Screenshot 2023-04-07 at 5 38 43 PM

Case 3: Upgrade - New Block scripts UI in the Shields panel - PASSED

Steps:

  1. installed 1.50.114
  2. launched Brave
  3. visited huffpost.com in a new tab
  4. clicked on Shields icon to open Shields panel
  5. toggled the Block scripts setting to On
  6. clicked on the blocked script count link (8)
  7. verified 8 blocked scripts shown
  8. closed the browser and renamed the profile to Brave-Browser-Beta
  9. installed 1.51.80
  10. confirmed new UI (Allow all) is shown
  11. clicked Allow all
  12. confirmed Allow all and Block all scripts shown
  13. clicked <--- Shields to return the Shields panel
  14. confirmed blocked scripts count shown (11)
  15. clicked again on the block script count
  16. clicked Block all to return show blocked scripts
  17. clicked allow/block on individual scripts
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel show correct blocked count next to Block scripts setting
step 7 step 10-11 step 12 step 14 step 17
Screenshot 2023-04-07 at 5 48 12 PM Screenshot 2023-04-07 at 5 50 13 PM Screenshot 2023-04-07 at 5 50 26 PM Screenshot 2023-04-07 at 5 51 10 PM Screenshot 2023-04-07 at 5 51 14 PM

Verification passed on

Brave 1.51.98 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Ubuntu 22.04 LTS

Case 1: Per-site - Block/Allow Block scripts setting via Shields panel - PASSED

Steps:

  1. installed 1.51.98
  2. launched Brave
  3. loaded https://www.nbcnews.com/now in a new tab
  4. clicked on Shields icon to open Shields panel
  5. toggled Block scripts setting to On
  6. clicked on the blocked script count link (38)
  7. clicked Allow all
  8. confirmed Allowed scripts (37) and Blocked scripts (3) shown
  9. clicked <--- Shields to return the Shields panel
  10. confirmed blocked scripts count shown (37)
  11. clicked again on the block script count
  12. clicked Block all to return show blocked scripts
  13. clicked allow/block on individual scripts
  • Confirmed able to toggle scripts via Allow all and Block all
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel shows correct blocked count next to Block scripts setting
image image image image

Case 2: Global settings - Block/Allow Block scripts setting via brave://settings/shields - PASSED

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/shields
  4. toggled Block scripts setting to On
  5. opened https://www.rt.com in a new tab
  6. clicked on Shields icon to open Shields panel
  7. confirmed Block scripts is enabled and count (9) shown
  8. clicked through to see the breakdown
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel shows correct blocked count next to Block scripts setting
image image image

Case 3: Upgrade - New Block scripts UI in the Shields panel - PASSED

Steps:

  1. installed 1.50.114
  2. launched Brave
  3. visited huffpost.com in a new tab
  4. clicked on Shields icon to open Shields panel
  5. toggled the Block scripts setting to On
  6. clicked on the blocked script count link (8)
  7. verified 8 blocked scripts shown
  8. closed the browser and renamed the profile to Brave-Browser-Beta
  9. installed 1.51.98
  10. confirmed new UI (Allow all) is shown
  11. clicked Allow all
  12. confirmed Allow all and Block all scripts shown
  13. clicked <--- Shields to return the Shields panel
  14. confirmed blocked scripts count shown (11)
  15. clicked again on the block script count
  16. clicked Block all to return show blocked scripts
  17. clicked allow/block on individual scripts
  • Confirmed able to toggle Allow all and Block all scripts
  • Confirmed able to toggle allow/block individual and embedded scripts
  • Confirmed Shields panel show correct blocked count next to Block scripts setting

image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 8, 2023
@stephendonner
Copy link

Logged #29585 which I found whilst testing this issue.

@rebron rebron changed the title re-add the ability to allow/block individual scripts in Shields (webui part) Re-add the ability to allow/block individual scripts in Shields (webui part) Apr 26, 2023
@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

re-add the ability to allow/block individual scripts in Shields (webui part) brave/brave-core
6 participants
@stephendonner @spylogsster @LaurenWags @btlechowski @brave-builds @MadhaviSeelam