Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave-Payments-Environment should send production instead of empty string #28554

Closed
bsclifton opened this issue Feb 16, 2023 · 3 comments · Fixed by brave/brave-core#17244
Closed

Brave-Payments-Environment should send production instead of empty string #28554

bsclifton opened this issue Feb 16, 2023 · 3 comments · Fixed by brave/brave-core#17244
Assignees
@simonhong
Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.49.x - Release #2

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 16, 2023 •
edited
Loading

Test plan

See brave/brave-core#17244

Description

When making a request to Guardian VPN to create a Brave VPN subscriber credential, empty string is passed for production.
https://github.com/brave/brave-core/blob/ab958d9b789e5e53360374270440d49dfde905b8/components/brave_vpn/common/brave_vpn_utils.cc#L127-L128

We should be passing the string production
@simonhong simonhong self-assigned this Feb 16, 2023
@simonhong simonhong mentioned this issue Feb 16, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 16, 2023
@simonhong
Pass "production" as vpn payment env value in prod env
7e84a62 
fix brave/brave-browser#28554
@bsclifton bsclifton added this to the 1.50.x - Nightly milestone Feb 17, 2023
@brave-builds brave-builds mentioned this issue Feb 17, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.49.115 or higher for 1.49.x verification 👍

@stephendonner
Copy link

stephendonner commented Mar 4, 2023 •
edited
Loading

Verified PASSED using

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 10 Version 22H2 (Build 19045.2673)

Steps:

  1. installed 1.49.118
  2. launched Brave using `brave.exe --enable-logging=stdrr --vmodule=vpn=2
  3. enabled Brave VPN using brave://flags
  4. clicked on Relaunch
  5. purchased, configured, and connected to Brave VPN
  6. switched server regions
  7. examined the logs

image

Confirmed:

[9208:19164:0304/150759.307:VERBOSE2:brave_vpn_os_connection_api_base.cc(401)] ParseAndCacheHostnames : request profile credential:production [9208:19164:0304/150759.754:VERBOSE2:brave_vpn_os_connection_api_base.cc(423)] OnGetProfileCredentials : received profile credential

Full logs:

[9208:19164:0304/150757.456:VERBOSE2:brave_vpn_service.cc(554)] GetPurchasedState : PURCHASED
[9208:19164:0304/150757.473:VERBOSE2:brave_vpn_service.cc(579)] LoadPurchasedState: Set as a purchased user as we have valid subscriber credentials & region data
[9208:19164:0304/150757.491:VERBOSE2:brave_vpn_service.cc(187)] GetConnectionState : DISCONNECTED
[9208:19164:0304/150757.491:VERBOSE2:brave_vpn_service.cc(404)] GetSelectedRegion [9208:19164:0304/150758.917:VERBOSE2:brave_vpn_os_connection_api_base.cc(102)] Connect : start connecting!
[9208:19164:0304/150758.917:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTED to CONNECTING
[9208:19164:0304/150758.918:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECTING
[9208:19164:0304/150758.918:VERBOSE2:brave_vpn_os_connection_api_base.cc(331)] FetchHostnamesForRegion
[9208:19164:0304/150759.307:VERBOSE2:brave_vpn_os_connection_api_base.cc(353)] OnFetchHostnames
[9208:19164:0304/150759.307:VERBOSE2:brave_vpn_os_connection_api_base.cc(391)] ParseAndCacheHostnames : Picked sanjose-5.sgw.guardianapp.com, San Jose, CA, 0, 1
[9208:19164:0304/150759.307:VERBOSE2:brave_vpn_os_connection_api_base.cc(401)] ParseAndCacheHostnames : request profile credential:production
[9208:19164:0304/150759.754:VERBOSE2:brave_vpn_os_connection_api_base.cc(423)] OnGetProfileCredentials : received profile credential
[9208:19164:0304/150759.773:VERBOSE2:brave_vpn_os_connection_api_base.cc(179)] OnCreated
[9208:19164:0304/150800.165:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150800.165:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from CONNECTING to CONNECTED
[9208:19164:0304/150800.165:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECTED
[9208:19164:0304/150802.548:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 6
[9208:19164:0304/150802.549:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 0
[9208:19164:0304/150802.552:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150802.552:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150808.568:VERBOSE2:brave_vpn_service.cc(579)] LoadPurchasedState: Set as a purchased user as we have valid subscriber credentials & region data
[9208:19164:0304/150813.449:VERBOSE2:brave_vpn_service.cc(433)] SetSelectedRegion : USA (Northwest)
[9208:19164:0304/150813.450:VERBOSE2:brave_vpn_os_connection_api_base.cc(170)] ResetConnectionInfo
[9208:19164:0304/150813.450:VERBOSE2:brave_vpn_os_connection_api_base.cc(136)] Disconnect : start disconnecting!
[9208:19164:0304/150813.450:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from CONNECTED to DISCONNECTING
[9208:19164:0304/150813.450:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged DISCONNECTING
[9208:19164:0304/150813.585:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTING to DISCONNECTED
[9208:19164:0304/150813.586:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged DISCONNECTED
[9208:19164:0304/150813.586:VERBOSE2:brave_vpn_os_connection_api_base.cc(102)] Connect : start connecting!
[9208:19164:0304/150813.586:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTED to CONNECTING
[9208:19164:0304/150813.586:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECTING
[9208:19164:0304/150813.586:VERBOSE2:brave_vpn_os_connection_api_base.cc(331)] FetchHostnamesForRegion
[9208:19164:0304/150813.587:VERBOSE2:brave_vpn_os_connection_api_base.cc(274)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[9208:19164:0304/150813.587:VERBOSE2:brave_vpn_os_connection_api_base.cc(274)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[9208:19164:0304/150813.588:VERBOSE2:brave_vpn_os_connection_api_base.cc(353)] OnFetchHostnames
[9208:19164:0304/150813.588:VERBOSE2:brave_vpn_os_connection_api_base.cc(356)] OnFetchHostnames : failed to fetch hostnames for us-north-west
[9208:19164:0304/150813.588:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from CONNECTING to CONNECT_FAILED
[9208:19164:0304/150813.588:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECT_FAILED
[9208:19164:0304/150813.594:WARNING:CONSOLE(954)] "Connection has failed", source: chrome-untrusted://vpn-panel.top-chrome/brave_vpn_panel.bundle.js (954)
[9208:19164:0304/150815.032:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 6
[9208:19164:0304/150815.034:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 2
[9208:19164:0304/150815.037:VERBOSE2:brave_vpn_os_connection_api_base.cc(282)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state after connect failed [9208:19164:0304/150815.037:VERBOSE2:brave_vpn_os_connection_api_base.cc(282)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state after connect failed [9208:19164:0304/150815.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(102)] Connect : start connecting!
[9208:19164:0304/150815.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from CONNECT_FAILED to CONNECTING
[9208:19164:0304/150815.687:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECTING
[9208:19164:0304/150815.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(331)] FetchHostnamesForRegion
[9208:19164:0304/150815.998:VERBOSE2:brave_vpn_os_connection_api_base.cc(353)] OnFetchHostnames
[9208:19164:0304/150815.998:VERBOSE2:brave_vpn_os_connection_api_base.cc(391)] ParseAndCacheHostnames : Picked seattle-1.sgw.guardianapp.com, Seattle, WA, 0, 0
[9208:19164:0304/150815.998:VERBOSE2:brave_vpn_os_connection_api_base.cc(401)] ParseAndCacheHostnames : request profile credential:production
[9208:19164:0304/150816.396:VERBOSE2:brave_vpn_os_connection_api_base.cc(423)] OnGetProfileCredentials : received profile credential
[9208:19164:0304/150816.412:VERBOSE2:brave_vpn_os_connection_api_base.cc(179)] OnCreated
[9208:19164:0304/150816.810:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150816.810:VERBOSE2:brave_vpn_os_connection_api_base.cc(286)] UpdateAndNotifyConnectionStateChange : changing from CONNECTING to CONNECTED
[9208:19164:0304/150816.812:VERBOSE2:brave_vpn_service.cc(136)] OnConnectionStateChanged CONNECTED
[9208:19164:0304/150817.111:INFO:CONSOLE(0)] "The resource https://account.brave.com/images/brave-icons.svg was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.", source: https://account.brave.com/account/?intent=provision&order_id=8699f58e-7f44-4c2c-a260-e5fbbeba9ce3 (0)
[9208:19164:0304/150818.247:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 6
[9208:19164:0304/150818.247:VERBOSE2:brave_vpn_os_connection_api_base.cc(255)] OnNetworkChanged : 0
[9208:19164:0304/150818.254:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150818.257:VERBOSE2:brave_vpn_os_connection_api_base.cc(202)] OnConnected
[9208:19164:0304/150824.138:VERBOSE2:brave_vpn_service.cc(579)] LoadPurchasedState: Set as a purchased user as we have valid subscriber credentials & region data
[24144:4732:0304/150913.858:WARNING:spdy_session.cc(3484)] Received HEADERS for invalid stream 5

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 5G using version(s):

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 13;

Using Test Plan in brave/brave-core#17244 (comment)

  1. Install 1.49.120 but DO NOT Launch app
  2. Enable airplane mode on device
  3. Now launch brave app
  4. Enabled developer mode
  5. Enter QA pref
  6. set --enable-logging=stderr --vmodule=*vpn*=2 for command line string but No not relaunch app yet
  7. Close app
  8. Disable airplane mode on device, confirm network connection is established
  9. Open brave app
  10. Purchase VPN
  11. Change server location
  12. Confirm VPN server host change
  • Confirmed user is able to enabled VPN profile
  • Confirmed changing VPN host is working and host is updated
Example Example Example
screenshot-1678399403394 screenshot-1678399410986 screenshot-1678399419046

Captured Logs using adb logcat

03-09 17:01:46.138  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState LOADING
03-09 17:01:46.138  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(588)] LoadPurchasedState: Checking purchased state as we doesn't have valid subscriber credentials
03-09 17:01:46.146  9612  9612 V chromium: [VERBOSE1:brave_vpn_service.cc(624)] OnCredentialSummary : Credential is not active.
03-09 17:01:46.146  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState NOT_PURCHASED
^C
sergeymesheryakov@Sergeys-Work-MacBook ~ % adb logcat | grep -i "brave_vpn"
03-09 16:55:43.199  3341  3341 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState LOADING
03-09 16:55:43.200  3341  3341 V chromium: [VERBOSE2:brave_vpn_service.cc(588)] LoadPurchasedState: Checking purchased state as we doesn't have valid subscriber credentials
03-09 16:55:43.210  3341  3341 V chromium: [VERBOSE1:brave_vpn_service.cc(624)] OnCredentialSummary : Credential is not active.
03-09 16:55:43.211  3341  3341 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState NOT_PURCHASED
03-09 17:01:46.138  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState LOADING
03-09 17:01:46.138  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(588)] LoadPurchasedState: Checking purchased state as we doesn't have valid subscriber credentials
03-09 17:01:46.146  9612  9612 V chromium: [VERBOSE1:brave_vpn_service.cc(624)] OnCredentialSummary : Credential is not active.
03-09 17:01:46.146  9612  9612 V chromium: [VERBOSE2:brave_vpn_service.cc(829)] SetPurchasedState NOT_PURCHASED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release #2
Development

Successfully merging a pull request may close this issue.

Pass "production" as vpn payment env value in prod env brave/brave-core
6 participants
@stephendonner @kjozwiak @bsclifton @simonhong @Uni-verse @brave-builds