Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline Tip button tooltips on hover #28699

Closed
Miyayes opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-site-specific-scripts#94
Closed

Remove inline Tip button tooltips on hover #28699

Miyayes opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-site-specific-scripts#94
Assignees
@emerick
Labels
feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
Greaselion 1.0.408

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 22, 2023

Description

Due to bugs and inconsistency with how these tooltips can appear, we will remove them.
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Mar 1, 2023
@emerick emerick mentioned this issue Mar 6, 2023
Merged
@emerick emerick added this to the Greaselion Next milestone Mar 7, 2023
@emerick emerick mentioned this issue Mar 10, 2023
Closed
@mkarolin mkarolin mentioned this issue Mar 15, 2023
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 8, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.56.20 Chromium: 115.0.5790.171 (Official Build) (64-bit)
-- | --
Revision | cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS | Windows 10 Version 22H2 (Build 19045.3208)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.942

image

Launched 1.56.20 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.942. Confirmed that there is no inline Tip button tooltip for the Twitter and Reddit publishers

https://twitter.com/brave
https://twitter.com/bravelaurenwags
http://reddit.com/u/beachbum0407
https://www.reddit.com/u/kjozwiak

Example Example Example Example
image image image image

Verification PASSED on

Brave | 1.56.20 Chromium: 115.0.5790.171 (Official Build) (arm64)
-- | --
Revision | cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS | macOS Version 12.5 (Build 21G72)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.942

image

Launched 1.56.20 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.942. Confirmed that there is no inline Tip button tooltip for the Twitter and Reddit publishers

https://twitter.com/brave
https://twitter.com/bravelaurenwags
http://reddit.com/u/beachbum0407
https://www.reddit.com/u/kjozwiak

Example Example Example Example
Screenshot 2023-08-08 at 8 39 41 PM Screenshot 2023-08-08 at 8 41 42 PM Screenshot 2023-08-08 at 8 43 23 PM Screenshot 2023-08-08 at 8 44 41 PM

@emerick
Copy link
Contributor

emerick commented Aug 8, 2023

This is in Greaselion 1.0.408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
Greaselion 1.0.408
Development

Successfully merging a pull request may close this issue.

Remove inline tips hover text brave/brave-site-specific-scripts
3 participants
@emerick @Miyayes @GeetaSarvadnya