Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify media type before pinning an NFT #28775

Closed
cypt4 opened this issue Feb 27, 2023 · 2 comments · Fixed by brave/brave-core#17392
Closed

Verify media type before pinning an NFT #28775

cypt4 opened this issue Feb 27, 2023 · 2 comments · Fixed by brave/brave-core#17392
Assignees
@cypt4
Labels
feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@cypt4
Copy link

cypt4 commented Feb 27, 2023

According sec review https://github.com/brave/security/issues/1182#issuecomment-1434728109 we should verify that content has supported media format before pinning.
At the moment image is only supported format.
@cypt4 cypt4 added OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support release-notes/exclude labels Feb 27, 2023
@cypt4 cypt4 self-assigned this Feb 27, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Feb 27, 2023
@cypt4
Verify NFT content media type before pinning
4dc49bf 
Resolves brave/brave-browser#28775
cypt4 added a commit to brave/brave-core that referenced this issue Feb 27, 2023
@cypt4
Verify NFT content media type before pinning
c3d51b0 
Resolves brave/brave-browser#28775
@cypt4 cypt4 mentioned this issue Feb 27, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Mar 5, 2023
@cypt4
Verify NFT content media type before pinning
e37f4be 
Resolves brave/brave-browser#28775
cypt4 added a commit to brave/brave-core that referenced this issue Mar 6, 2023
@cypt4
Verify NFT content media type before pinning (#17392)
bf8d546 
* Verify NFT content media type before pinning
Allow pinnning only if metadata and image has ipfs format
Resolves brave/brave-browser#28775
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 6, 2023
@brave-builds brave-builds mentioned this issue Mar 10, 2023
Merged
7 tasks
@cypt4 cypt4 mentioned this issue Mar 13, 2023
Closed
@kjozwiak
Copy link
Member

The above requires 1.50.94 or higher for 1.50.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Mar 20, 2023 •
edited
Loading

Verification passed on

Brave 1.50.94 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
Pinning success Pinning failure
image image

Verification passed on

Brave 1.50.94 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
Pinning success Pinning failure
image image

@srirambv srirambv mentioned this issue Apr 6, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Verify NFT content media type before pinning brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @cypt4