Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads box should respect rewards status #2922

Closed
NejcZdovc opened this issue Jan 11, 2019 · 1 comment · Fixed by brave/brave-core#1297
Closed

Ads box should respect rewards status #2922

NejcZdovc opened this issue Jan 11, 2019 · 1 comment · Fixed by brave/brave-core#1297
Assignees
@NejcZdovc
Labels
feature/ads feature/rewards OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Description

When you disable rewards, ads box should be disabled as well.

Current:
image

Should be like auto contribute
@NejcZdovc NejcZdovc self-assigned this Jan 11, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 11, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 11, 2019
@NejcZdovc
Fixes rewards disabled for ads
e156e02 
Resolves brave/brave-browser#2922
@NejcZdovc NejcZdovc mentioned this issue Jan 11, 2019
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 11, 2019
@NejcZdovc
Fixes rewards disabled for ads
b35ccf1 
Resolves brave/brave-browser#2922
@NejcZdovc NejcZdovc mentioned this issue Jan 11, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 11, 2019
This was referenced Feb 15, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Feb 15, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from brave/brave-core#1297

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/ads feature/rewards OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes rewards disabled for ads brave/brave-core
5 participants
@rebron @NejcZdovc @srirambv @LaurenWags @btlechowski