Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Automatically pin NFTs settings doesn't update the IPFS banner on portfolio/nft page #29354

Closed
srirambv opened this issue Mar 28, 2023 · 2 comments · Fixed by brave/brave-core#17983

Comments

@srirambv
Copy link
Contributor

Description

Disabling Automatically pin NFTs settings doesn't update the IPFS banner on portfolio/nft page

Steps to Reproduce

  1. Add an NFT and enable pinning
  2. Go to brave://settings/web3 and disable Automatically pin NFTs
  3. Go back to wallet, IPFS pinning banner doesn't update from You’re running IPFS node. File is being fetched to local IPFS node. to IPFS pinning banner

Actual result:

IPFS-NFT.Banner.mp4

Expected result:

Should update the banner when setting is disabled without requiring a page refresh

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Windows 11 Version 22H2 (Build 22621.1344)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @cypt4 @yrliou

@kjozwiak
Copy link
Member

The above requires 1.51.95 or higher for 1.51.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1555)
  • Verified steps from brave/brave-core#17983
  • Verified disabling Automatically pin NFTs setting auto-updates the IPFS banner on Portfolio/NFT page
29354.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants