Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing pinned NFT still shows NFT data is being pinned to your local IPFS node on NFT details screen #29553

Closed
srirambv opened this issue Apr 6, 2023 · 2 comments · Fixed by brave/brave-core#17983

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2023

Description

Clearing pinned NFT still shows NFT data is being pinned to your local IPFS node on NFT details screen

Steps to Reproduce

  1. Add a few NFT's and pin them
  2. Ensure NFT show successfully pinned message
  3. Disable auto-pinning NFT from setting
  4. Click on Clear Pinned NFT
  5. Go back to NFT details view
  6. Banner changes to Learn more
  7. Open NFT details view
  8. Shows NFT data is being pinned to your local IPFS node
  9. Restart browser, continues to show the message from step 8

Actual result:

Cleanup.NFT.Pinning.mp4

Expected result:

Should not show NFT data is being pinned to your local IPFS node on NFT details screen when Clear pinned NFT is selected

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.52.17 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 11 Version 22H2 (Build 23424.1000)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4

@kjozwiak
Copy link
Member

The above requires 1.51.95 or higher for 1.51.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1555)
  • Verified steps from brave/brave-core#17983
  • Verified adding an NFT from the same collection automatically shows the pinning status and doesn't require browser restart
29553.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants