-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM distiller used for ads causes various widespread webcompat issues #2991
Milestone
Comments
bridiver
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
… called. This maintains the original behavior from https://chromium.googlesource.com/chromium/src/+/fb688daf52cef3bb041634888583ee2c28c8af66%5E%21/components/dom_distiller/content/distiller_page_web_contents.cc without breaking sites that use the original webcontents Fix brave/brave-browser#2991 Fix brave/brave-browser#2901
18 tasks
bridiver
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
… called. This maintains the original behavior from https://chromium.googlesource.com/chromium/src/+/fb688daf52cef3bb041634888583ee2c28c8af66%5E%21/components/dom_distiller/content/distiller_page_web_contents.cc without breaking sites that use the original webcontents Fix brave/brave-browser#2991 Fix brave/brave-browser#2901
18 tasks
bridiver
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
… called. This maintains the original behavior from https://chromium.googlesource.com/chromium/src/+/fb688daf52cef3bb041634888583ee2c28c8af66%5E%21/components/dom_distiller/content/distiller_page_web_contents.cc without breaking sites that use the original webcontents Fix brave/brave-browser#2991 Fix brave/brave-browser#2901
18 tasks
Verification passed on
Used pages from the description. Verification passed on
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DOM Distiller is causing sites to not load XHR properly
Description
Several sites are broken if you turn on ads because of DOM distiller.
custody.coinbase.com doesn't load
Going to Github and clicking on closed issues doesn't load them
Various other webcompat issues across various sites
Steps to Reproduce
Actual result:
Site doesn't load, only the background image.
Expected result:
Site should load.
Reproduces how often:
Always for me
Brave version (brave://version info)
0.59.2 and above.
Reproducible on current release:
Only on Dev and Beta, not on Release channel
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: