Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM distiller used for ads causes various widespread webcompat issues #2991

Closed
bbondy opened this issue Jan 16, 2019 · 1 comment · Fixed by brave/brave-core#1361
Closed

Comments

@bbondy
Copy link
Member

bbondy commented Jan 16, 2019

DOM Distiller is causing sites to not load XHR properly

Description

Several sites are broken if you turn on ads because of DOM distiller.
custody.coinbase.com doesn't load
Going to Github and clicking on closed issues doesn't load them
Various other webcompat issues across various sites

Steps to Reproduce

  1. Turn on ads
  2. Go to custody.coinbase.com

Actual result:

Site doesn't load, only the background image.

Expected result:

Site should load.

Reproduces how often:

Always for me

Brave version (brave://version info)

0.59.2 and above.

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Only on Dev and Beta, not on Release channel

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No, but if you turn off ads it works.
  • Is the issue reproducible on the latest version of Chrome? No.

Additional Information

@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 16, 2019
@btlechowski
Copy link

btlechowski commented Jan 22, 2019

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

Used pages from the description.
custody.coinbase.com - renders the same as in Chrome 71.0.3578.98
github.com - closed issues are now loaded

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux
  • Although ads not applicable on Linux, verified the pages from description and works fine

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment