Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Swap 2.0 components into Wallet brave-core #30370

Closed
Douglashdaniel opened this issue May 16, 2023 · 2 comments · Fixed by brave/brave-core#18562
Closed

Migrate Swap 2.0 components into Wallet brave-core #30370

Douglashdaniel opened this issue May 16, 2023 · 2 comments · Fixed by brave/brave-core#18562
Assignees
@onyb @Douglashdaniel
Labels
dev-experience feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.57.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to move all of the Swap 2.0 components into brave-core
https://github.com/brave/swap/tree/master/interface/src/components
@Douglashdaniel Douglashdaniel added QA/No release-notes/exclude dev-experience feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels May 16, 2023
@Douglashdaniel Douglashdaniel self-assigned this May 16, 2023
@Douglashdaniel Douglashdaniel changed the title Move Swap 2.0 components into Wallet brave-core Migrate Swap 2.0 components into Wallet brave-core May 18, 2023
@onyb onyb self-assigned this May 22, 2023
@onyb onyb mentioned this issue May 22, 2023
Merged
25 tasks
@onyb onyb added OS/Android Fixes related to Android browser functionality QA/Yes and removed QA/No labels May 22, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone May 25, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.27 Chromium: 115.0.5790.1314 (Official Build) beta (64-bit)
Revision 18977fb43f693d5a8deeb48bd1cfa52651d3f73e
OS Windows 11 Version 22H2 (Build 22621.1992)

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.57.44 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

@Douglashdaniel Douglashdaniel

Labels
dev-experience feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

chore(wallet): migrate swap to brave-core brave/brave-core
4 participants
@onyb @srirambv @Douglashdaniel @brave-builds