-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): migrate swap to brave-core #18562
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @brave/[email protected] |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/apeswap.svg
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/apeswap.svg
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/ironswap.svg
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/penguin.svg
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/shibaswap.svg
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/stepn.svg
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/stepn.svg
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/assets/lp-icons/sushiswap.svg
Show resolved
Hide resolved
@onyb left a couple of comments |
b786278
to
37dea58
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
db128d8
to
db3c59f
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deps ok
Signed-off-by: Vadym Struts <[email protected]>
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Resolves brave/brave-browser#30370
Note to @brave/js-deps-reviewers
@brave/swap-interface
is removed frompackage.json
.async
npm library is added topackage.json
. It was one of the dependencies of@brave/swap-interface
.Note to other reviewers
Added some
FIXME(douglashdaniel)
and optionalFIXME(josheleonard)
comments for @Douglashdaniel and @josheleonard respectively.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please test all aspects of 0x and Jupiter swaps on desktop and android.