Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo input field should start as one line height and expand, allowing multiple lines #32062

Closed
rebron opened this issue Aug 3, 2023 · 5 comments · Fixed by brave/brave-core#21124
Assignees
Labels
browser-ai front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 3, 2023

Description

Line height for the input field should start off as one line and expand.
And we should allow multiple lines (shift-enter or paste)

Actual result:

Screenshot 2023-08-02 at 1 26 49 PM

Expected result:

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Desktop browser-ai priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude labels Aug 3, 2023
@aguscruiz
Copy link

Adding screenshots if necessary:

Initial state
image

Max height
image

@bbondy bbondy added front-end-change This task is a front end task and doesn't need any C++ changes QA/Yes and removed QA/No labels Sep 4, 2023
@petemill petemill changed the title Leo input field should start as one line height and expand Leo input field should start as one line height and expand, allowing multiple lines Oct 27, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 27, 2023
@stephendonner
Copy link

Verified PASSED using

Brave | 1.63.101 Chromium: 120.0.6099.199 (Official Build) nightly (x86_64)
-- | --
Revision | 8d3f0a563e185b6a763cc8e210ab24775dfb9047
OS | macOS Version 14.3 (Build 23D5043d)

Steps:

  1. install 1.63.101
  2. launched Brave
  3. loaded https://www.nbcnews.com/news/us-news/united-finds-bolts-need-tightening-inspections-door-plugs-grounded-boe-rcna132879
  4. clicked on Leo in the sidebar
  5. clicked on Accept and begin
  6. entered the following multi-line set of questions:
What's 4x4?
What's the square root of 16?
What's the square root of 100?
What's the current date and time?
What's the current weather?
  1. clicked on the Send message to Leo button
  2. waited for the response

Confirmed Leo answered all 5 of my multi-line questions

Screenshot 2024-01-08 at 2 01 10 PM

@kjozwiak
Copy link
Member

Removing QA Pass labels as the above will need to be re-checked using 1.62.x. However, used #32062 (comment) as the needed verification to get the above uplifted into 1.62.x.

Adding QA/Blocked for now as the above was merged into cr121-1.62.x via brave/brave-core#21593. Once C121 is merged into 1.62.x via brave/brave-core#21593, we'll unblock the above and mention the needed 1.62.x version for verification 👍

@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.62.149
  2. launched Brave
  3. opened a new-tab page
  4. opened Leo in the sidebar
  5. clicked on Accept and begin
  6. pasted the following and clicked return to send to Leo:
What's 4x4?
What's the square root of 16?
What's the square root of 100?
What's the current date and time?
What's the current weather?
  1. waited for Leo to answer

Confirmed Leo answered my 5 questions

Screen Shot 2024-01-22 at 12 41 37 PM

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants