Private and Tor windows NTP UI doesn't fill completely

[srirambv]

Description

Private and Tor windows NTP UI doesn't fill completely. Issue originally reported by @NejcZdovc

Steps to Reproduce

1. Install beta build
2. Open a new Tor/Private window
3. Shows white blank space at the bottom of the page

Actual result:

Private:
Tor:

Expected result:

UI should cover the entire page

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Linux/macOS

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes on beta and dev

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @rossmoody @petemill

[btlechowski]

Edit: Reproduced on Windows 7 x64 and Windows 10 x64 when zoomed out. Probably resolution dependent issue.

Brave	0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Windows

[kjozwiak]

Noticed the same thing happening on my macOS 10.14.2 x64 last night when I was using Tor windows. Using the following Display settings:

Example of the issue occurring (notice the white spaces at the bottom occurring):

[NejcZdovc]

personally I think this should be release blocking for 0.60 as it looks really bad, specially on big screen

[kjozwiak]

@NejcZdovc agreed. Looks like it's a regression and doesn't happen on 0.59.35. I double checked 0.59.35 and couldn't reproduce. This looks pretty bad and it's an obvious regressions. We're making the experience worse than it was one release before.

CCing @rebron on thoughts re: getting this fixed in 0.60.x.

[srirambv]

Verification passed on

Brave	0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Linux

• Private and Tor window NTP UI fills correctly on all resolution sizes

Verification passed on

Brave	0.60.34 Chromium: 72.0.3626.109 (Official Build) beta (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Windows 10

• Private and Tor window NTP UI fills correctly on all resolution sizes

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave	0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Mac OS X